From 6261592339cffd1d533716e638ea4f17c670f5d7 Mon Sep 17 00:00:00 2001 From: shancheas Date: Tue, 9 Jul 2024 17:47:15 +0700 Subject: [PATCH] lint: update type data and lint --- .../domain/services/privilege.service.ts | 2 +- .../managers/base-batch-delete.manager.ts | 2 +- .../base-batch-update-status.manager.ts | 2 +- .../strings/constants/interface.constants.ts | 2 +- .../1720436852936-update-table-transaction.ts | 37 ++++++++++++------- .../infrastructure/constant.controller.ts | 2 - .../domain/entities/cron-midnight.event.ts | 2 +- .../domain/managers/midnight-cron.manager.ts | 2 +- .../log/domain/handlers/error-log.handler.ts | 4 +- .../log/domain/handlers/log.handler.ts | 4 +- .../managers/create-item-category.manager.ts | 4 +- .../managers/index-item-rate.manager.ts | 2 +- .../managers/helpers/validate.helper.ts | 2 +- .../entities/filter-season-type.entity.ts | 2 +- .../entities/filter-vip-category.entity.ts | 2 +- .../managers/create-vip-category.manager.ts | 4 +- .../domain/entities/filter-vip-code.entity.ts | 2 +- .../managers/create-tenant.manager.ts | 4 +- .../entities/filter-user-privilege.entity.ts | 2 +- .../managers/create-user-privilege.manager.ts | 4 +- .../usecases/managers/create-user.manager.ts | 4 +- 21 files changed, 57 insertions(+), 34 deletions(-) diff --git a/src/core/guards/domain/services/privilege.service.ts b/src/core/guards/domain/services/privilege.service.ts index 27f6809..6cb2917 100644 --- a/src/core/guards/domain/services/privilege.service.ts +++ b/src/core/guards/domain/services/privilege.service.ts @@ -61,7 +61,7 @@ export class PrivilegeService { } async privilegeConfiguration(): Promise { - const { module, menu, sub_menu, section } = this.moduleKey(); + const { module, menu } = this.moduleKey(); return await this.repository.findOne({ select: ['id', 'view', 'create', 'edit', 'delete', 'cancel', 'confirm'], where: { diff --git a/src/core/modules/domain/usecase/managers/base-batch-delete.manager.ts b/src/core/modules/domain/usecase/managers/base-batch-delete.manager.ts index 374adcb..292c45d 100644 --- a/src/core/modules/domain/usecase/managers/base-batch-delete.manager.ts +++ b/src/core/modules/domain/usecase/managers/base-batch-delete.manager.ts @@ -25,7 +25,7 @@ export abstract class BaseBatchDeleteManager extends BaseManager { async process(): Promise { let totalFailed = 0; let totalSuccess = 0; - let messages = []; + const messages = []; for (const id of this.dataIds) { try { diff --git a/src/core/modules/domain/usecase/managers/base-batch-update-status.manager.ts b/src/core/modules/domain/usecase/managers/base-batch-update-status.manager.ts index 670e398..afc2680 100644 --- a/src/core/modules/domain/usecase/managers/base-batch-update-status.manager.ts +++ b/src/core/modules/domain/usecase/managers/base-batch-update-status.manager.ts @@ -29,7 +29,7 @@ export abstract class BaseBatchUpdateStatusManager extends BaseManager { async process(): Promise { let totalFailed = 0; let totalSuccess = 0; - let messages = []; + const messages = []; for (const id of this.dataIds) { try { diff --git a/src/core/strings/constants/interface.constants.ts b/src/core/strings/constants/interface.constants.ts index 4c092eb..c5ed49d 100644 --- a/src/core/strings/constants/interface.constants.ts +++ b/src/core/strings/constants/interface.constants.ts @@ -24,7 +24,7 @@ export interface validateRelations { export interface columnUniques { column: string; - query?: Object; + query?: any; } export interface IEvent { diff --git a/src/database/migrations/1720436852936-update-table-transaction.ts b/src/database/migrations/1720436852936-update-table-transaction.ts index f33630e..05e41b1 100644 --- a/src/database/migrations/1720436852936-update-table-transaction.ts +++ b/src/database/migrations/1720436852936-update-table-transaction.ts @@ -1,18 +1,29 @@ -import { MigrationInterface, QueryRunner } from "typeorm"; +import { MigrationInterface, QueryRunner } from 'typeorm'; export class UpdateTableTransaction1720436852936 implements MigrationInterface { - name = 'UpdateTableTransaction1720436852936' + name = 'UpdateTableTransaction1720436852936'; - public async up(queryRunner: QueryRunner): Promise { - await queryRunner.query(`ALTER TABLE "transaction_taxes" ADD "tax_total_value" numeric`); - await queryRunner.query(`ALTER TABLE "transaction_taxes" DROP COLUMN "taxt_value"`); - await queryRunner.query(`ALTER TABLE "transaction_taxes" ADD "taxt_value" numeric`); - } - - public async down(queryRunner: QueryRunner): Promise { - await queryRunner.query(`ALTER TABLE "transaction_taxes" DROP COLUMN "taxt_value"`); - await queryRunner.query(`ALTER TABLE "transaction_taxes" ADD "taxt_value" character varying`); - await queryRunner.query(`ALTER TABLE "transaction_taxes" DROP COLUMN "tax_total_value"`); - } + public async up(queryRunner: QueryRunner): Promise { + await queryRunner.query( + `ALTER TABLE "transaction_taxes" ADD "tax_total_value" numeric`, + ); + await queryRunner.query( + `ALTER TABLE "transaction_taxes" DROP COLUMN "taxt_value"`, + ); + await queryRunner.query( + `ALTER TABLE "transaction_taxes" ADD "taxt_value" numeric`, + ); + } + public async down(queryRunner: QueryRunner): Promise { + await queryRunner.query( + `ALTER TABLE "transaction_taxes" DROP COLUMN "taxt_value"`, + ); + await queryRunner.query( + `ALTER TABLE "transaction_taxes" ADD "taxt_value" character varying`, + ); + await queryRunner.query( + `ALTER TABLE "transaction_taxes" DROP COLUMN "tax_total_value"`, + ); + } } diff --git a/src/modules/configuration/constant/infrastructure/constant.controller.ts b/src/modules/configuration/constant/infrastructure/constant.controller.ts index 6c9e681..61bba1f 100644 --- a/src/modules/configuration/constant/infrastructure/constant.controller.ts +++ b/src/modules/configuration/constant/infrastructure/constant.controller.ts @@ -10,8 +10,6 @@ import { PaymentMethodType } from 'src/modules/transaction/payment-method/consta @Controller('v1/constant') @Public(true) export class ConstantController { - constructor() {} - @Get('master-data-status') async masterDataStatus(): Promise { return [STATUS.ACTIVE, STATUS.DRAFT, STATUS.INACTIVE]; diff --git a/src/modules/configuration/cron/domain/entities/cron-midnight.event.ts b/src/modules/configuration/cron/domain/entities/cron-midnight.event.ts index 17db760..c50b5b7 100644 --- a/src/modules/configuration/cron/domain/entities/cron-midnight.event.ts +++ b/src/modules/configuration/cron/domain/entities/cron-midnight.event.ts @@ -1,3 +1,3 @@ export class CronMidnightEvent { - constructor(public readonly data: {}) {} + // constructor(public readonly data: {}) {} } diff --git a/src/modules/configuration/cron/domain/managers/midnight-cron.manager.ts b/src/modules/configuration/cron/domain/managers/midnight-cron.manager.ts index cfdd044..3136421 100644 --- a/src/modules/configuration/cron/domain/managers/midnight-cron.manager.ts +++ b/src/modules/configuration/cron/domain/managers/midnight-cron.manager.ts @@ -16,6 +16,6 @@ export class MidnightCronManager { console.log('Cron Event executed every 00:00 minutes.', now); - this.eventBus.publishAll([new CronMidnightEvent({})]); + this.eventBus.publishAll([new CronMidnightEvent()]); } } diff --git a/src/modules/configuration/log/domain/handlers/error-log.handler.ts b/src/modules/configuration/log/domain/handlers/error-log.handler.ts index 906b0b3..f1e3c58 100644 --- a/src/modules/configuration/log/domain/handlers/error-log.handler.ts +++ b/src/modules/configuration/log/domain/handlers/error-log.handler.ts @@ -6,5 +6,7 @@ import { ErrorLogService } from '../../data/services/error-log.service'; export class RecordErrorLogHandler implements IEventHandler { constructor(private dataservice: ErrorLogService) {} - async handle(event: RecordErrorLog) {} + async handle(event: RecordErrorLog) { + // TODO: Implement logic here + } } diff --git a/src/modules/configuration/log/domain/handlers/log.handler.ts b/src/modules/configuration/log/domain/handlers/log.handler.ts index 54cb92e..1e4fafb 100644 --- a/src/modules/configuration/log/domain/handlers/log.handler.ts +++ b/src/modules/configuration/log/domain/handlers/log.handler.ts @@ -3,5 +3,7 @@ import { RecordLog } from '../entities/log.event'; @EventsHandler(RecordLog) export class RecordLogHandler implements IEventHandler { - async handle(event: RecordLog) {} + async handle(event: RecordLog) { + // TODO: Implement logic here + } } diff --git a/src/modules/item-related/item-category/domain/usecases/managers/create-item-category.manager.ts b/src/modules/item-related/item-category/domain/usecases/managers/create-item-category.manager.ts index 9007f3d..30725a3 100644 --- a/src/modules/item-related/item-category/domain/usecases/managers/create-item-category.manager.ts +++ b/src/modules/item-related/item-category/domain/usecases/managers/create-item-category.manager.ts @@ -22,7 +22,9 @@ export class CreateItemCategoryManager extends BaseCreateManager {} + async generateConfig(): Promise { + // TODO: Implement logic here + } get validateRelations(): validateRelations[] { return []; diff --git a/src/modules/item-related/item-rate/domain/usecases/managers/index-item-rate.manager.ts b/src/modules/item-related/item-rate/domain/usecases/managers/index-item-rate.manager.ts index 8d1559c..4f34708 100644 --- a/src/modules/item-related/item-rate/domain/usecases/managers/index-item-rate.manager.ts +++ b/src/modules/item-related/item-rate/domain/usecases/managers/index-item-rate.manager.ts @@ -19,7 +19,7 @@ export class IndexItemRateManager extends BaseIndexManager { async afterProcess(): Promise { this.result.data?.map((item) => { - let prices = []; + const prices = []; for ( let d = new Date(this.filterParam.start_date); d <= new Date(this.filterParam.end_date); diff --git a/src/modules/season-related/season-period/domain/usecases/managers/helpers/validate.helper.ts b/src/modules/season-related/season-period/domain/usecases/managers/helpers/validate.helper.ts index 643c425..199c78b 100644 --- a/src/modules/season-related/season-period/domain/usecases/managers/helpers/validate.helper.ts +++ b/src/modules/season-related/season-period/domain/usecases/managers/helpers/validate.helper.ts @@ -21,7 +21,7 @@ export async function ValidateSeasonPeriodHelper(dataService, data) { => akan tetapi dapat ditindih oleh season period 2024-08-15, 2024-08-28 days [Sabtu, Senin] (karena ini naik prio menjadi priority 2) */ const query = dataService.getRepository().createQueryBuilder('data'); - let priority: number = 3; + let priority = 3; // libur / specific date if ( data.holidays?.length > 0 || diff --git a/src/modules/season-related/season-type/domain/entities/filter-season-type.entity.ts b/src/modules/season-related/season-type/domain/entities/filter-season-type.entity.ts index bbdfd80..8ceaa32 100644 --- a/src/modules/season-related/season-type/domain/entities/filter-season-type.entity.ts +++ b/src/modules/season-related/season-type/domain/entities/filter-season-type.entity.ts @@ -1,3 +1,3 @@ import { BaseFilterEntity } from 'src/core/modules/domain/entities/base-filter.entity'; -export interface FilterSeasonTypeEntity extends BaseFilterEntity {} +export type FilterSeasonTypeEntity = BaseFilterEntity; diff --git a/src/modules/transaction/vip-category/domain/entities/filter-vip-category.entity.ts b/src/modules/transaction/vip-category/domain/entities/filter-vip-category.entity.ts index bb53a73..e23eaaa 100644 --- a/src/modules/transaction/vip-category/domain/entities/filter-vip-category.entity.ts +++ b/src/modules/transaction/vip-category/domain/entities/filter-vip-category.entity.ts @@ -1,3 +1,3 @@ import { BaseFilterEntity } from 'src/core/modules/domain/entities/base-filter.entity'; -export interface FilterVipCategoryEntity extends BaseFilterEntity {} +export type FilterVipCategoryEntity = BaseFilterEntity; diff --git a/src/modules/transaction/vip-category/domain/usecases/managers/create-vip-category.manager.ts b/src/modules/transaction/vip-category/domain/usecases/managers/create-vip-category.manager.ts index d2f77ac..83a2421 100644 --- a/src/modules/transaction/vip-category/domain/usecases/managers/create-vip-category.manager.ts +++ b/src/modules/transaction/vip-category/domain/usecases/managers/create-vip-category.manager.ts @@ -19,7 +19,9 @@ export class CreateVipCategoryManager extends BaseCreateManager {} + async generateConfig(): Promise { + // TODO: Implement logic here + } get validateRelations(): validateRelations[] { return []; diff --git a/src/modules/transaction/vip-code/domain/entities/filter-vip-code.entity.ts b/src/modules/transaction/vip-code/domain/entities/filter-vip-code.entity.ts index e971665..bb7ec07 100644 --- a/src/modules/transaction/vip-code/domain/entities/filter-vip-code.entity.ts +++ b/src/modules/transaction/vip-code/domain/entities/filter-vip-code.entity.ts @@ -1,3 +1,3 @@ import { BaseFilterEntity } from 'src/core/modules/domain/entities/base-filter.entity'; -export interface FilterVipCodeEntity extends BaseFilterEntity {} +export type FilterVipCodeEntity = BaseFilterEntity; diff --git a/src/modules/user-related/tenant/domain/usecases/managers/create-tenant.manager.ts b/src/modules/user-related/tenant/domain/usecases/managers/create-tenant.manager.ts index 65b4736..3067935 100644 --- a/src/modules/user-related/tenant/domain/usecases/managers/create-tenant.manager.ts +++ b/src/modules/user-related/tenant/domain/usecases/managers/create-tenant.manager.ts @@ -30,7 +30,9 @@ export class CreateTenantManager extends BaseCreateManager { return; } - async generateConfig(): Promise {} + async generateConfig(): Promise { + // TODO: Implement logic here + } get uniqueColumns(): columnUniques[] { return [ diff --git a/src/modules/user-related/user-privilege/domain/entities/filter-user-privilege.entity.ts b/src/modules/user-related/user-privilege/domain/entities/filter-user-privilege.entity.ts index cb66f26..eb95688 100644 --- a/src/modules/user-related/user-privilege/domain/entities/filter-user-privilege.entity.ts +++ b/src/modules/user-related/user-privilege/domain/entities/filter-user-privilege.entity.ts @@ -1,3 +1,3 @@ import { BaseFilterEntity } from 'src/core/modules/domain/entities/base-filter.entity'; -export interface FilterUserPrivilegeEntity extends BaseFilterEntity {} +export type FilterUserPrivilegeEntity = BaseFilterEntity; diff --git a/src/modules/user-related/user-privilege/domain/usecases/user-privilege/managers/create-user-privilege.manager.ts b/src/modules/user-related/user-privilege/domain/usecases/user-privilege/managers/create-user-privilege.manager.ts index 7fc5836..f0b8d1b 100644 --- a/src/modules/user-related/user-privilege/domain/usecases/user-privilege/managers/create-user-privilege.manager.ts +++ b/src/modules/user-related/user-privilege/domain/usecases/user-privilege/managers/create-user-privilege.manager.ts @@ -24,7 +24,9 @@ export class CreateUserPrivilegeManager extends BaseCreateManager {} + async generateConfig(): Promise { + // TODO: Implement logic here + } get uniqueColumns(): columnUniques[] { return [{ column: 'name' }]; diff --git a/src/modules/user-related/user/domain/usecases/managers/create-user.manager.ts b/src/modules/user-related/user/domain/usecases/managers/create-user.manager.ts index 8251a31..ba2c477 100644 --- a/src/modules/user-related/user/domain/usecases/managers/create-user.manager.ts +++ b/src/modules/user-related/user/domain/usecases/managers/create-user.manager.ts @@ -31,7 +31,9 @@ export class CreateUserManager extends BaseCreateManager { return; } - async generateConfig(): Promise {} + async generateConfig(): Promise { + // TODO: Implement logic here + } get validateRelations(): validateRelations[] { return [];