From e25ad6500f6d3c287dd5d00dd3c925a720bd8f91 Mon Sep 17 00:00:00 2001 From: shancheas Date: Thu, 26 Jun 2025 11:26:55 +0700 Subject: [PATCH] fix: simplify query conditions in item managers by removing unnecessary status checks --- .../item/domain/usecases/managers/create-item.manager.ts | 3 +-- .../item/domain/usecases/managers/update-item.manager.ts | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/modules/item-related/item/domain/usecases/managers/create-item.manager.ts b/src/modules/item-related/item/domain/usecases/managers/create-item.manager.ts index db1c055..ffe59fc 100644 --- a/src/modules/item-related/item/domain/usecases/managers/create-item.manager.ts +++ b/src/modules/item-related/item/domain/usecases/managers/create-item.manager.ts @@ -52,13 +52,12 @@ export class CreateItemManager extends BaseCreateManager { ? [ { column: 'name', - query: `(status = '${STATUS.ACTIVE}' AND (${this.tableName}.time_group_id Is Null OR ${this.tableName}.time_group_id = '${timeGroupId}'))`, + query: `((${this.tableName}.time_group_id Is Null OR ${this.tableName}.time_group_id = '${timeGroupId}'))`, }, ] : [ { column: 'name', - query: `(status = '${STATUS.ACTIVE}')`, }, ]; } diff --git a/src/modules/item-related/item/domain/usecases/managers/update-item.manager.ts b/src/modules/item-related/item/domain/usecases/managers/update-item.manager.ts index bfc9620..105ada2 100644 --- a/src/modules/item-related/item/domain/usecases/managers/update-item.manager.ts +++ b/src/modules/item-related/item/domain/usecases/managers/update-item.manager.ts @@ -62,7 +62,7 @@ export class UpdateItemManager extends BaseUpdateManager { return [ { column: 'name', - query: `(status = '${STATUS.ACTIVE}' AND (${this.tableName}.time_group_id Is Null OR ${this.tableName}.time_group_id = '${timeGroupId}'))`, + query: `((${this.tableName}.time_group_id Is Null OR ${this.tableName}.time_group_id = '${timeGroupId}'))`, }, ]; }