Compare commits

...

15 Commits

Author SHA1 Message Date
shancheas b96d24de1a feat: add query filter for active booking items in BookingItemManager 2025-06-24 12:44:00 +07:00
shancheas 5d3f9d7bff fix(SPG-1254): ONLINE BOOKING wahana tenant tidak muncul pada catalog online booking 2025-06-24 11:51:43 +07:00
shancheas 831593e743 Merge branch 'development' of ssh://git.eigen.co.id:2222/eigen/pos-be into development 2025-06-20 14:48:55 +07:00
shancheas 162bd0918f fix: ensure safe access to season period IDs in booking item pricing logic 2025-06-20 14:48:45 +07:00
firmanr 13b5838393 Merge pull request 'feat(SPG-1137): add time group at booking and refund detail' (#161) from feat/otp-cancel into development
Reviewed-on: #161
2025-06-19 18:43:57 +07:00
Firman Ramdhani 63bb55b04b feat(SPG-1137): add time group at booking and refund detail 2025-06-19 18:30:07 +07:00
firmanr 9d1c240b6b Merge pull request 'feat(SPG-1236): setup otp checker guard' (#160) from feat/otp-cancel into development
Reviewed-on: #160
2025-06-19 17:10:07 +07:00
Firman Ramdhani 83f3377465 feat(SPG-1236): setup otp checker guard 2025-06-19 17:09:42 +07:00
firmanr 69c2ee06cf Merge pull request 'feat(SPG-1236): implement otp checker guard on session period' (#159) from feat/otp-cancel into development
Reviewed-on: #159
2025-06-19 17:04:51 +07:00
Firman Ramdhani 42060384aa feat(SPG-1236): implement otp checker guard on session period 2025-06-19 17:04:07 +07:00
firmanr 62cfb1f1a8 Merge pull request 'feat/otp-cancel' (#158) from feat/otp-cancel into development
Reviewed-on: #158
2025-06-19 16:36:52 +07:00
Firman Ramdhani 08a35dfdf4 feat(SPG-1236): implement otp checker guard on booking transaction 2025-06-19 16:32:48 +07:00
Firman Ramdhani 8df836ff3e feat(SPG-1236): implement otp checker guard on session period 2025-06-19 16:24:20 +07:00
Firman Ramdhani 822cfe606a feat(SPG-1236): implement otp checker guard on active and confirm user 2025-06-19 15:55:19 +07:00
Firman Ramdhani de43f0f28b feat(SPG-1236): setup otp checker guard 2025-06-19 15:55:01 +07:00
14 changed files with 108 additions and 12 deletions

View File

@ -106,6 +106,7 @@ import { OtpVerificationModule } from './modules/configuration/otp-verification/
import { OtpVerificationModel } from './modules/configuration/otp-verification/data/models/otp-verification.model'; import { OtpVerificationModel } from './modules/configuration/otp-verification/data/models/otp-verification.model';
import { OtpVerifierModel } from './modules/configuration/otp-verification/data/models/otp-verifier.model'; import { OtpVerifierModel } from './modules/configuration/otp-verification/data/models/otp-verifier.model';
import { RescheduleVerificationModel } from './modules/booking-online/order/data/models/reschedule-verification.model'; import { RescheduleVerificationModel } from './modules/booking-online/order/data/models/reschedule-verification.model';
import { OtpCheckerGuard } from './core/guards/domain/otp-checker.guard';
@Module({ @Module({
imports: [ imports: [
@ -246,6 +247,8 @@ import { RescheduleVerificationModel } from './modules/booking-online/order/data
providers: [ providers: [
AuthService, AuthService,
PrivilegeService, PrivilegeService,
OtpCheckerGuard,
/** /**
* By default all request from client will protect by JWT * By default all request from client will protect by JWT
* if there is some endpoint/function that does'nt require authentication * if there is some endpoint/function that does'nt require authentication

View File

@ -0,0 +1,57 @@
import {
CanActivate,
ExecutionContext,
Injectable,
UnprocessableEntityException,
} from '@nestjs/common';
import { InjectDataSource } from '@nestjs/typeorm';
import { CONNECTION_NAME } from 'src/core/strings/constants/base.constants';
import { OtpVerificationModel } from 'src/modules/configuration/otp-verification/data/models/otp-verification.model';
import { OtpVerificationEntity } from 'src/modules/configuration/otp-verification/domain/entities/otp-verification.entity';
import { DataSource } from 'typeorm';
@Injectable()
export class OtpCheckerGuard implements CanActivate {
constructor(
@InjectDataSource(CONNECTION_NAME.DEFAULT)
protected readonly dataSource: DataSource,
) {}
get otpRepository() {
return this.dataSource.getRepository(OtpVerificationModel);
}
async canActivate(context: ExecutionContext): Promise<boolean> {
const request = context.switchToHttp().getRequest();
const verificationCode = request.headers['x-verification-code'];
console.log({ verificationCode });
if (verificationCode) {
const decoded = Buffer.from(verificationCode, 'base64').toString('ascii');
const [dataIdentity, otpCode] = decoded.split('|');
let otpData: OtpVerificationEntity;
otpData = await this.otpRepository.findOne({
where: {
otp_code: otpCode,
target_id: dataIdentity,
},
});
if (!otpData) {
otpData = await this.otpRepository.findOne({
where: {
otp_code: otpCode,
reference: dataIdentity,
},
});
}
// console.log({ dataIdentity, otpCode, otpData });
if (otpData && otpData?.verified_at) return true;
}
throw new UnprocessableEntityException('OTP not verified.');
}
}

View File

@ -43,7 +43,7 @@ export class BookingItemManager extends IndexItemManager {
const hasRates = (this.filterParam.season_period_ids?.length ?? 0) > 0; const hasRates = (this.filterParam.season_period_ids?.length ?? 0) > 0;
const items = data.map((item) => { const items = data.map((item) => {
const currentRate = item.item_rates.find((rate) => const currentRate = item.item_rates.find((rate) =>
this.filterParam.season_period_ids.includes(rate.season_period_id), this.filterParam.season_period_ids?.includes(rate.season_period_id),
); );
const { item_rates, ...rest } = item; const { item_rates, ...rest } = item;
const rate = currentRate?.['price'] ?? rest.base_price; const rate = currentRate?.['price'] ?? rest.base_price;
@ -54,4 +54,14 @@ export class BookingItemManager extends IndexItemManager {
}); });
return { total, data: items }; return { total, data: items };
} }
setQueryFilter(
queryBuilder: SelectQueryBuilder<ItemEntity>,
): SelectQueryBuilder<ItemEntity> {
const query = super.setQueryFilter(queryBuilder);
query.andWhere(`${this.tableName}.status = 'active'`);
return query;
}
} }

View File

@ -23,6 +23,7 @@ export class ItemController {
): Promise<PaginationResponse<ItemEntity>> { ): Promise<PaginationResponse<ItemEntity>> {
params.limit = 1000; params.limit = 1000;
params.show_to_booking = true; params.show_to_booking = true;
params.all_item = true;
this.indexManager.setFilterParam(params); this.indexManager.setFilterParam(params);
this.indexManager.setService(this.serviceData, TABLE_NAME.ITEM); this.indexManager.setService(this.serviceData, TABLE_NAME.ITEM);
await this.indexManager.execute(); await this.indexManager.execute();

View File

@ -16,7 +16,7 @@ import {
OtpVerifierCreateDto, OtpVerifierCreateDto,
OtpVerifyDto, OtpVerifyDto,
} from './dto/otp-verification.dto'; } from './dto/otp-verification.dto';
import { OtpAuthGuard } from './guards/otp-auth-guard'; import { OtpAuthGuard } from './guards/otp-auth.guard';
import { OtpVerifierService } from '../data/services/otp-verifier.service'; import { OtpVerifierService } from '../data/services/otp-verifier.service';
@ApiTags(`${MODULE_NAME.OTP_VERIFICATIONS.split('-').join(' ')} - data`) @ApiTags(`${MODULE_NAME.OTP_VERIFICATIONS.split('-').join(' ')} - data`)

View File

@ -10,7 +10,7 @@ import {
} from './infrastructure/otp-verification-data.controller'; } from './infrastructure/otp-verification-data.controller';
import { OtpVerificationService } from './data/services/otp-verification.service'; import { OtpVerificationService } from './data/services/otp-verification.service';
import { OtpVerifierModel } from './data/models/otp-verifier.model'; import { OtpVerifierModel } from './data/models/otp-verifier.model';
import { OtpAuthGuard } from './infrastructure/guards/otp-auth-guard'; import { OtpAuthGuard } from './infrastructure/guards/otp-auth.guard';
import { JwtModule } from '@nestjs/jwt'; import { JwtModule } from '@nestjs/jwt';
import { JWT_EXPIRED } from 'src/core/sessions/constants'; import { JWT_EXPIRED } from 'src/core/sessions/constants';

View File

@ -6,6 +6,7 @@ import {
Patch, Patch,
Post, Post,
Put, Put,
UseGuards,
} from '@nestjs/common'; } from '@nestjs/common';
import { ItemDataOrchestrator } from '../domain/usecases/item-data.orchestrator'; import { ItemDataOrchestrator } from '../domain/usecases/item-data.orchestrator';
import { ItemDto } from './dto/item.dto'; import { ItemDto } from './dto/item.dto';
@ -16,6 +17,7 @@ import { BatchResult } from 'src/core/response/domain/ok-response.interface';
import { BatchIdsDto } from 'src/core/modules/infrastructure/dto/base-batch.dto'; import { BatchIdsDto } from 'src/core/modules/infrastructure/dto/base-batch.dto';
import { Public } from 'src/core/guards'; import { Public } from 'src/core/guards';
import { UpdateItemPriceDto } from './dto/update-item-price.dto'; import { UpdateItemPriceDto } from './dto/update-item-price.dto';
import { OtpCheckerGuard } from 'src/core/guards/domain/otp-checker.guard';
@ApiTags(`${MODULE_NAME.ITEM.split('-').join(' ')} - data`) @ApiTags(`${MODULE_NAME.ITEM.split('-').join(' ')} - data`)
@Controller(`v1/${MODULE_NAME.ITEM}`) @Controller(`v1/${MODULE_NAME.ITEM}`)
@ -41,19 +43,18 @@ export class ItemDataController {
} }
@Patch(':id/active') @Patch(':id/active')
// TODO => simpan OTP update yang disikim dari request ini @UseGuards(OtpCheckerGuard)
async active(@Param('id') dataId: string): Promise<string> { async active(@Param('id') dataId: string): Promise<string> {
return await this.orchestrator.active(dataId); return await this.orchestrator.active(dataId);
} }
@Put('/batch-active') @Put('/batch-active')
// TODO => simpan OTP update yang disikim dari request ini
async batchActive(@Body() body: BatchIdsDto): Promise<BatchResult> { async batchActive(@Body() body: BatchIdsDto): Promise<BatchResult> {
return await this.orchestrator.batchActive(body.ids); return await this.orchestrator.batchActive(body.ids);
} }
@Patch(':id/confirm') @Patch(':id/confirm')
// TODO => simpan OTP update yang disikim dari request ini @UseGuards(OtpCheckerGuard)
async confirm(@Param('id') dataId: string): Promise<string> { async confirm(@Param('id') dataId: string): Promise<string> {
return await this.orchestrator.confirm(dataId); return await this.orchestrator.confirm(dataId);
} }
@ -74,7 +75,7 @@ export class ItemDataController {
} }
@Put(':id') @Put(':id')
// TODO => simpan OTP update yang disikim dari request ini @UseGuards(OtpCheckerGuard)
async update( async update(
@Param('id') dataId: string, @Param('id') dataId: string,
@Body() data: ItemDto, @Body() data: ItemDto,

View File

@ -6,6 +6,7 @@ import {
Patch, Patch,
Post, Post,
Put, Put,
UseGuards,
} from '@nestjs/common'; } from '@nestjs/common';
import { SeasonPeriodDataOrchestrator } from '../domain/usecases/season-period-data.orchestrator'; import { SeasonPeriodDataOrchestrator } from '../domain/usecases/season-period-data.orchestrator';
import { SeasonPeriodDto } from './dto/season-period.dto'; import { SeasonPeriodDto } from './dto/season-period.dto';
@ -18,6 +19,7 @@ import { Public } from 'src/core/guards';
import { UpdateSeasonPeriodDto } from './dto/update-season-period.dto'; import { UpdateSeasonPeriodDto } from './dto/update-season-period.dto';
import { UpdateSeasonPeriodItemDto } from './dto/update-season-period-item.dto'; import { UpdateSeasonPeriodItemDto } from './dto/update-season-period-item.dto';
import { UpdateSeasonPriceDto } from './dto/update-season-price.dto'; import { UpdateSeasonPriceDto } from './dto/update-season-price.dto';
import { OtpCheckerGuard } from 'src/core/guards/domain/otp-checker.guard';
@ApiTags(`${MODULE_NAME.SEASON_PERIOD.split('-').join(' ')} - data`) @ApiTags(`${MODULE_NAME.SEASON_PERIOD.split('-').join(' ')} - data`)
@Controller(`v1/${MODULE_NAME.SEASON_PERIOD}`) @Controller(`v1/${MODULE_NAME.SEASON_PERIOD}`)
@ -27,11 +29,13 @@ export class SeasonPeriodDataController {
constructor(private orchestrator: SeasonPeriodDataOrchestrator) {} constructor(private orchestrator: SeasonPeriodDataOrchestrator) {}
@Post() @Post()
@UseGuards(OtpCheckerGuard)
async create(@Body() data: SeasonPeriodDto): Promise<SeasonPeriodEntity> { async create(@Body() data: SeasonPeriodDto): Promise<SeasonPeriodEntity> {
return await this.orchestrator.create(data); return await this.orchestrator.create(data);
} }
@Post('/update-price') @Post('/update-price')
@UseGuards(OtpCheckerGuard)
async updatePrice(@Body() body: UpdateSeasonPriceDto): Promise<BatchResult> { async updatePrice(@Body() body: UpdateSeasonPriceDto): Promise<BatchResult> {
return await this.orchestrator.updatePrice(body); return await this.orchestrator.updatePrice(body);
} }
@ -82,6 +86,7 @@ export class SeasonPeriodDataController {
// pemisahan update data dengan update items dikarenakan payload (based on tampilan) berbeda // pemisahan update data dengan update items dikarenakan payload (based on tampilan) berbeda
// TODO => simpan OTP update yang disikim dari request ini // TODO => simpan OTP update yang disikim dari request ini
@Put(':id/items') @Put(':id/items')
@UseGuards(OtpCheckerGuard)
async updateItems( async updateItems(
@Param('id') dataId: string, @Param('id') dataId: string,
@Body() data: UpdateSeasonPeriodItemDto, @Body() data: UpdateSeasonPeriodItemDto,

View File

@ -31,6 +31,10 @@ export class DetailRefundManager extends BaseDetailManager<RefundEntity> {
'items.bundling_items', 'items.bundling_items',
'items.refunds item_refunds', 'items.refunds item_refunds',
'item_refunds.refund item_refunds_refund', 'item_refunds.refund item_refunds_refund',
'transaction.items transaction_items',
'transaction_items.item transaction_items_item',
'transaction_items_item.time_group transaction_items_item_time_group',
], ],
// relation yang hanya ingin dihitung (akan return number) // relation yang hanya ingin dihitung (akan return number)
@ -65,6 +69,10 @@ export class DetailRefundManager extends BaseDetailManager<RefundEntity> {
'item_refunds', 'item_refunds',
'item_refunds_refund.id', 'item_refunds_refund.id',
'item_refunds_refund.status', 'item_refunds_refund.status',
'transaction_items',
'transaction_items_item',
'transaction_items_item_time_group',
]; ];
} }

View File

@ -31,6 +31,9 @@ export class DetailTransactionManager extends BaseDetailManager<TransactionEntit
'items.refunds item_refunds', 'items.refunds item_refunds',
'item_refunds.refund item_refunds_refund', 'item_refunds.refund item_refunds_refund',
'refunds', 'refunds',
'items.item items_item',
'items_item.time_group items_item_time_group',
], ],
// relation yang hanya ingin dihitung (akan return number) // relation yang hanya ingin dihitung (akan return number)
@ -92,6 +95,8 @@ export class DetailTransactionManager extends BaseDetailManager<TransactionEntit
'item_refunds_refund.status', 'item_refunds_refund.status',
'refunds', 'refunds',
'items_item',
'items_item_time_group',
]; ];
} }

View File

@ -43,6 +43,8 @@ export function mappingTransaction(data, refundId?: string) {
if (refundId) if (refundId)
refund = itemData.refunds?.find((item) => item.refund.id == refundId); refund = itemData.refunds?.find((item) => item.refund.id == refundId);
const timeGroup = itemData?.item?.time_group;
return { return {
item: { item: {
id: itemData.item_id, id: itemData.item_id,
@ -57,6 +59,7 @@ export function mappingTransaction(data, refundId?: string) {
}, },
breakdown_bundling: itemData.breakdown_bundling, breakdown_bundling: itemData.breakdown_bundling,
bundling_items: itemData.bundling_items, bundling_items: itemData.bundling_items,
time_group: timeGroup,
}, },
id: itemData.id, id: itemData.id,
refund: refund, refund: refund,

View File

@ -20,7 +20,8 @@ import { BatchResult } from 'src/core/response/domain/ok-response.interface';
import { BatchIdsDto } from 'src/core/modules/infrastructure/dto/base-batch.dto'; import { BatchIdsDto } from 'src/core/modules/infrastructure/dto/base-batch.dto';
import { Public } from 'src/core/guards'; import { Public } from 'src/core/guards';
import { DownloadPdfDto } from './dto/donwload-pdf.dto'; import { DownloadPdfDto } from './dto/donwload-pdf.dto';
import { OtpAuthGuard } from 'src/modules/configuration/otp-verification/infrastructure/guards/otp-auth-guard'; import { OtpAuthGuard } from 'src/modules/configuration/otp-verification/infrastructure/guards/otp-auth.guard';
import { OtpCheckerGuard } from 'src/core/guards/domain/otp-checker.guard';
@ApiTags(`${MODULE_NAME.TRANSACTION.split('-').join(' ')} - data`) @ApiTags(`${MODULE_NAME.TRANSACTION.split('-').join(' ')} - data`)
@Controller(`v1/${MODULE_NAME.TRANSACTION}`) @Controller(`v1/${MODULE_NAME.TRANSACTION}`)
@ -53,6 +54,7 @@ export class TransactionDataController {
} }
@Patch(':id/confirm-data') @Patch(':id/confirm-data')
@UseGuards(OtpCheckerGuard)
async confirmData(@Param('id') dataId: string): Promise<string> { async confirmData(@Param('id') dataId: string): Promise<string> {
return await this.orchestrator.confirmData(dataId); return await this.orchestrator.confirmData(dataId);
} }
@ -63,6 +65,7 @@ export class TransactionDataController {
} }
@Patch(':id/confirm') @Patch(':id/confirm')
@UseGuards(OtpCheckerGuard)
async confirm(@Param('id') dataId: string): Promise<string> { async confirm(@Param('id') dataId: string): Promise<string> {
return await this.orchestrator.confirm(dataId); return await this.orchestrator.confirm(dataId);
} }

View File

@ -6,6 +6,7 @@ import {
Patch, Patch,
Post, Post,
Put, Put,
UseGuards,
} from '@nestjs/common'; } from '@nestjs/common';
import { UserDataOrchestrator } from '../domain/usecases/user-data.orchestrator'; import { UserDataOrchestrator } from '../domain/usecases/user-data.orchestrator';
import { UserDto } from './dto/user.dto'; import { UserDto } from './dto/user.dto';
@ -17,6 +18,7 @@ import { BatchIdsDto } from 'src/core/modules/infrastructure/dto/base-batch.dto'
import { Public } from 'src/core/guards'; import { Public } from 'src/core/guards';
import { UpdateUserDto } from './dto/update-user.dto'; import { UpdateUserDto } from './dto/update-user.dto';
import { UpdatePasswordUserDto } from './dto/update-password-user.dto'; import { UpdatePasswordUserDto } from './dto/update-password-user.dto';
import { OtpCheckerGuard } from 'src/core/guards/domain/otp-checker.guard';
@ApiTags(`${MODULE_NAME.USER.split('-').join(' ')} - data`) @ApiTags(`${MODULE_NAME.USER.split('-').join(' ')} - data`)
@Controller(`v1/${MODULE_NAME.USER}`) @Controller(`v1/${MODULE_NAME.USER}`)
@ -36,25 +38,23 @@ export class UserDataController {
} }
@Patch(':id/active') @Patch(':id/active')
// TODO => simpan OTP update yang disikim dari request ini @UseGuards(OtpCheckerGuard)
async active(@Param('id') dataId: string): Promise<string> { async active(@Param('id') dataId: string): Promise<string> {
return await this.orchestrator.active(dataId); return await this.orchestrator.active(dataId);
} }
@Put('/batch-active') @Put('/batch-active')
// TODO => simpan OTP update yang disikim dari request ini
async batchActive(@Body() body: BatchIdsDto): Promise<BatchResult> { async batchActive(@Body() body: BatchIdsDto): Promise<BatchResult> {
return await this.orchestrator.batchActive(body.ids); return await this.orchestrator.batchActive(body.ids);
} }
@Patch(':id/confirm') @Patch(':id/confirm')
// TODO => simpan OTP update yang disikim dari request ini @UseGuards(OtpCheckerGuard)
async confirm(@Param('id') dataId: string): Promise<string> { async confirm(@Param('id') dataId: string): Promise<string> {
return await this.orchestrator.confirm(dataId); return await this.orchestrator.confirm(dataId);
} }
@Put('/batch-confirm') @Put('/batch-confirm')
// TODO => simpan OTP update yang disikim dari request ini
async batchConfirm(@Body() body: BatchIdsDto): Promise<BatchResult> { async batchConfirm(@Body() body: BatchIdsDto): Promise<BatchResult> {
return await this.orchestrator.batchConfirm(body.ids); return await this.orchestrator.batchConfirm(body.ids);
} }