Compare commits

..

14 Commits

Author SHA1 Message Date
shancheas be24ac02f7 Merge branch 'development' of ssh://git.eigen.co.id:2222/eigen/pos-be into development 2025-06-26 18:14:37 +07:00
shancheas fd8b7cc45e fix: update validation logic in item managers to use 'not in' for time_group_id checks and enhance relation handling 2025-06-26 18:14:26 +07:00
firmanr 0c65754b2d Merge pull request 'feat: change message otp credential not match' (#162) from feat/otp-cancel into development
Reviewed-on: #162
2025-06-26 18:05:32 +07:00
shancheas 14a86343df fix: enhance ticket retrieval logic to validate UUID format and adjust query conditions accordingly 2025-06-26 18:05:02 +07:00
Firman Ramdhani 1e692b0b4c feat: change message otp credential not match 2025-06-26 18:04:55 +07:00
shancheas 99889f425a fix: update singleQuery logic in item managers to use 'in' for time_group_id validation 2025-06-26 16:49:43 +07:00
shancheas db7bd81eac fix: update uniqueColumns logic in UpdateItemManager to handle null time_group_id 2025-06-26 15:36:57 +07:00
shancheas fcf9e9459e fix: enhance relation validation logic to check for existing relations in data 2025-06-26 15:12:08 +07:00
shancheas 2c92d4b8b3 fix(SPG-1270): add information date to message notification 2025-06-26 13:55:06 +07:00
shancheas 58e062dd6c fix(SPG-1218): sync midtrans status 2025-06-26 13:54:30 +07:00
shancheas e1d8975dda fix: update ticket retrieval logic to include booking date in query conditions 2025-06-26 11:27:31 +07:00
shancheas e25ad6500f fix: simplify query conditions in item managers by removing unnecessary status checks 2025-06-26 11:26:55 +07:00
shancheas 7bb539db0c fix(SPG-1266): Penyesuaian time zone server untuk field pilih waktu - meminimalisasi timezone user/ client 2025-06-25 16:39:01 +07:00
shancheas 92b54635d0 fix(SPG-1262): ONLINE BOOKING - Redirect ke antrian jika tidak sama dengan today - seharusnya diarahkan ke halaman login jika invoice tidak sama dengan today 2025-06-25 15:48:59 +07:00
13 changed files with 110 additions and 28 deletions

View File

@ -52,10 +52,12 @@ export class ValidateRelationHelper<Entity> {
`Failed! this data already connected to ${relation.relation}`; `Failed! this data already connected to ${relation.relation}`;
if (relation.singleQuery) { if (relation.singleQuery) {
const relationObject = data[relation.relation] ?? {};
const isRelationExist = `${relation.singleQuery[0]}` in relationObject;
const relationColumn = const relationColumn =
data[relation.relation]?.[`${relation.singleQuery[0]}`]; data[relation.relation]?.[`${relation.singleQuery[0]}`];
if ( if (
// !!relationColumn && isRelationExist &&
this.mappingValidator( this.mappingValidator(
relationColumn, relationColumn,
relation.singleQuery[1], relation.singleQuery[1],
@ -69,6 +71,7 @@ export class ValidateRelationHelper<Entity> {
} }
mappingValidator(column, operator, value) { mappingValidator(column, operator, value) {
const candidates = Array.isArray(value) ? value : [value];
switch (operator) { switch (operator) {
case '!=': case '!=':
return column != value; return column != value;
@ -76,6 +79,12 @@ export class ValidateRelationHelper<Entity> {
case '==': case '==':
return column == value; return column == value;
case 'in':
return candidates.includes(column);
case 'not in':
return !candidates.includes(column);
default: default:
return column == value; return column == value;
} }

View File

@ -21,6 +21,19 @@ export class MidtransService {
return diffInHours > 24; return diffInHours > 24;
} }
isCreatedMoreThan24HoursAgo(unixTimestamp) {
const date = moment.unix(unixTimestamp);
const now = moment();
const diffInHours = now.diff(date, 'hours');
return diffInHours > 24;
}
isBookingDateExpired(bookingDate) {
const bookingDateMoment = moment(bookingDate);
const today = moment().startOf('day');
return bookingDateMoment.isBefore(today);
}
get midtransInstance() { get midtransInstance() {
return new Snap({ return new Snap({
isProduction: false, isProduction: false,
@ -38,16 +51,18 @@ export class MidtransService {
const responses = []; const responses = [];
for (const transaction of pendingIds) { for (const transaction of pendingIds) {
const { id, invoice_date } = transaction; const { id, booking_date, created_at } = transaction;
let status; let status;
try { try {
status = await this.getStatus(id); status = await this.getStatus(id);
} catch (error) { } catch (error) {
status = { status = {
order_id: id, order_id: id,
transaction_status: this.isMoreThan24HoursAgo(invoice_date) transaction_status:
? 'cancel' this.isCreatedMoreThan24HoursAgo(created_at) ||
: 'pending', this.isBookingDateExpired(booking_date)
? 'expired'
: 'pending',
}; };
} }
responses.push(status); responses.push(status);

View File

@ -54,10 +54,12 @@ export class OtpAuthGuard implements CanActivate {
request.user = userLogin; request.user = userLogin;
return true; return true;
} else { } else {
throw new UnprocessableEntityException('Invalid OTP credentials'); throw new UnprocessableEntityException(
'Invalid username or password.',
);
} }
} catch (err) { } catch (err) {
throw new UnprocessableEntityException('Invalid OTP encoding'); throw new UnprocessableEntityException('Invalid username or password.');
} }
} }

View File

@ -32,7 +32,13 @@ export class ActiveItemManager extends BaseUpdateStatusManager<ItemEntity> {
} }
get validateRelations(): validateRelations[] { get validateRelations(): validateRelations[] {
return [ const timeGroupId = this.data.time_group_id ?? this.data.time_group?.id;
const relation =
this.data.bundling_items?.length > 0
? 'bundling_items'
: 'bundling_parents';
const validateRelations: validateRelations[] = [
{ {
relation: 'tenant', relation: 'tenant',
singleQuery: ['status', '!=', STATUS.ACTIVE], singleQuery: ['status', '!=', STATUS.ACTIVE],
@ -44,6 +50,16 @@ export class ActiveItemManager extends BaseUpdateStatusManager<ItemEntity> {
message: `Gagal! Terdapat item yang belum aktif`, message: `Gagal! Terdapat item yang belum aktif`,
}, },
]; ];
if (timeGroupId != null) {
validateRelations.push({
relation: relation,
singleQuery: ['time_group_id', 'not in', [timeGroupId, null]],
message: `Gagal Update! Time group item dan bundling item tidak sama`,
});
}
return validateRelations;
} }
get entityTarget(): any { get entityTarget(): any {

View File

@ -39,7 +39,7 @@ export class CreateItemManager extends BaseCreateManager<ItemEntity> {
? [ ? [
{ {
relation: relation, relation: relation,
singleQuery: ['time_group_id', '!=', timeGroupId], singleQuery: ['time_group_id', 'in', [timeGroupId, null]],
message: `Gagal Update! Time group item dan bundling item tidak sama`, message: `Gagal Update! Time group item dan bundling item tidak sama`,
}, },
] ]
@ -52,13 +52,12 @@ export class CreateItemManager extends BaseCreateManager<ItemEntity> {
? [ ? [
{ {
column: 'name', column: 'name',
query: `(status = '${STATUS.ACTIVE}' AND (${this.tableName}.time_group_id Is Null OR ${this.tableName}.time_group_id = '${timeGroupId}'))`, query: `((${this.tableName}.time_group_id Is Null OR ${this.tableName}.time_group_id = '${timeGroupId}'))`,
}, },
] ]
: [ : [
{ {
column: 'name', column: 'name',
query: `(status = '${STATUS.ACTIVE}')`,
}, },
]; ];
} }

View File

@ -50,7 +50,7 @@ export class UpdateItemManager extends BaseUpdateManager<ItemEntity> {
? [ ? [
{ {
relation: relation, relation: relation,
singleQuery: ['time_group_id', '!=', timeGroupId], singleQuery: ['time_group_id', 'not in', [timeGroupId, null]],
message: `Gagal Update! Time group item dan bundling item tidak sama`, message: `Gagal Update! Time group item dan bundling item tidak sama`,
}, },
] ]
@ -59,12 +59,18 @@ export class UpdateItemManager extends BaseUpdateManager<ItemEntity> {
get uniqueColumns(): columnUniques[] { get uniqueColumns(): columnUniques[] {
const timeGroupId = this.data.time_group_id ?? this.data.time_group?.id; const timeGroupId = this.data.time_group_id ?? this.data.time_group?.id;
return [ return timeGroupId != null
{ ? [
column: 'name', {
query: `(status = '${STATUS.ACTIVE}' AND (${this.tableName}.time_group_id Is Null OR ${this.tableName}.time_group_id = '${timeGroupId}'))`, column: 'name',
}, query: `((${this.tableName}.time_group_id Is Null OR ${this.tableName}.time_group_id = '${timeGroupId}'))`,
]; },
]
: [
{
column: 'name',
},
];
} }
get entityTarget(): any { get entityTarget(): any {

View File

@ -6,6 +6,8 @@ import {
Param, Param,
RelationParam, RelationParam,
} from 'src/core/modules/domain/entities/base-filter.entity'; } from 'src/core/modules/domain/entities/base-filter.entity';
import * as moment from 'moment';
import { ORDER_TYPE } from 'src/core/strings/constants/base.constants';
// TODO: // TODO:
// Implementasikan filter by start_time, end_timen, dan max_usage_time // Implementasikan filter by start_time, end_timen, dan max_usage_time
@ -13,6 +15,10 @@ import {
@Injectable() @Injectable()
export class IndexPublicTimeGroupManager extends BaseIndexManager<TimeGroupEntity> { export class IndexPublicTimeGroupManager extends BaseIndexManager<TimeGroupEntity> {
async prepareData(): Promise<void> { async prepareData(): Promise<void> {
Object.assign(this.filterParam, {
order_by: `${this.tableName}.start_time`,
order_type: ORDER_TYPE.ASC,
});
return; return;
} }
@ -60,6 +66,15 @@ export class IndexPublicTimeGroupManager extends BaseIndexManager<TimeGroupEntit
queryBuilder: SelectQueryBuilder<TimeGroupEntity>, queryBuilder: SelectQueryBuilder<TimeGroupEntity>,
): SelectQueryBuilder<TimeGroupEntity> { ): SelectQueryBuilder<TimeGroupEntity> {
queryBuilder.andWhere(`items.id is not null`); queryBuilder.andWhere(`items.id is not null`);
if (!this.filterParam.date) {
const currentTime = moment().utcOffset('+07:00').format('HH:mm:ss');
queryBuilder.andWhere(`${this.tableName}.end_time >= :current_time`, {
current_time: currentTime,
});
}
return queryBuilder; return queryBuilder;
} }
} }

View File

@ -30,4 +30,12 @@ export class FilterTimeGroupDto
@ApiProperty({ type: 'string', required: false }) @ApiProperty({ type: 'string', required: false })
@ValidateIf((body) => body.max_usage_time_to) @ValidateIf((body) => body.max_usage_time_to)
max_usage_time_to: string; max_usage_time_to: string;
@ApiProperty({
type: Date,
required: false,
example: '2024-01-01',
})
@ValidateIf((body) => body.date)
date: Date;
} }

View File

@ -52,11 +52,15 @@ export class TicketDataService extends BaseDataService<QueueTicket> {
}); });
if (!order) { if (!order) {
// Check if id is a valid UUID format
const uuidRegex =
/^[0-9a-f]{8}-[0-9a-f]{4}-[1-5][0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/i;
const whereCondition = !uuidRegex.test(id)
? { invoice_code: id, booking_date: new Date() }
: { id, booking_date: new Date() };
const { customer_name, customer_phone } = const { customer_name, customer_phone } =
await this.transaction.findOneOrFail({ await this.transaction.findOneOrFail({
where: { where: whereCondition,
id,
},
}); });
const start = moment().startOf('day').valueOf(); const start = moment().startOf('day').valueOf();

View File

@ -56,7 +56,7 @@ export class QueueOrchestrator {
return order; return order;
} catch (error) { } catch (error) {
throw new UnauthorizedException({ throw new UnauthorizedException({
message: 'Invoice tidak ditemukan', message: 'Invoice tidak ditemukan untuk tanggal hari ini',
error: 'INVOICE_NOT_FOUND', error: 'INVOICE_NOT_FOUND',
}); });
} }

View File

@ -27,6 +27,7 @@ export class GenerateQueueManager {
async generate(transaction: TransactionModel) { async generate(transaction: TransactionModel) {
const date = transaction.booking_date ?? transaction.invoice_date; const date = transaction.booking_date ?? transaction.invoice_date;
const queue_date = moment(date, 'YYYY-MM-DD').unix(); const queue_date = moment(date, 'YYYY-MM-DD').unix();
const isToday = moment(date, 'YYYY-MM-DD').isSame(moment(), 'day');
const { id, customer_name, customer_phone, invoice_code } = transaction; const { id, customer_name, customer_phone, invoice_code } = transaction;
@ -40,10 +41,9 @@ export class GenerateQueueManager {
const items = this.generateItems(transaction.items); const items = this.generateItems(transaction.items);
const existTicket = await this.ticketService.ticketByUser( const existTicket = isToday
customer_name, ? await this.ticketService.ticketByUser(customer_name, customer_phone)
customer_phone, : null;
);
const insertTickets: QueueTicket[] = []; const insertTickets: QueueTicket[] = [];
if (customer_name && customer_phone && existTicket) { if (customer_name && customer_phone && existTicket) {

View File

@ -8,7 +8,7 @@ import {
} from 'src/core/strings/constants/base.constants'; } from 'src/core/strings/constants/base.constants';
import { Repository } from 'typeorm'; import { Repository } from 'typeorm';
import { BaseReadService } from 'src/core/modules/data/service/base-read.service'; import { BaseReadService } from 'src/core/modules/data/service/base-read.service';
import { TransactionPaymentType } from '../../constants'; import { TransactionPaymentType, TransactionType } from '../../constants';
@Injectable() @Injectable()
export class TransactionReadService extends BaseReadService<TransactionEntity> { export class TransactionReadService extends BaseReadService<TransactionEntity> {
@ -24,8 +24,9 @@ export class TransactionReadService extends BaseReadService<TransactionEntity> {
where: { where: {
status: STATUS.PENDING, status: STATUS.PENDING,
payment_type: TransactionPaymentType.MIDTRANS, payment_type: TransactionPaymentType.MIDTRANS,
type: TransactionType.ONLINE,
}, },
select: ['id', 'invoice_date'], select: ['id', 'invoice_date', 'created_at', 'booking_date'],
}); });
return transactions; return transactions;

View File

@ -332,6 +332,8 @@ export class WhatsappService {
const momentDate = moment(data.time); const momentDate = moment(data.time);
const fallbackValue = momentDate.locale('id').format('dddd, DD MMMM YYYY'); const fallbackValue = momentDate.locale('id').format('dddd, DD MMMM YYYY');
const currentDate = moment().locale('id').format('DD MMMM YYYY');
const formattedTotal = new Intl.NumberFormat('id-ID', { const formattedTotal = new Intl.NumberFormat('id-ID', {
style: 'currency', style: 'currency',
currency: 'IDR', currency: 'IDR',
@ -364,6 +366,11 @@ export class WhatsappService {
parameter_name: 'booking_date', parameter_name: 'booking_date',
text: fallbackValue, text: fallbackValue,
}, },
{
type: 'text',
parameter_name: 'created_date',
text: currentDate,
},
{ {
type: 'text', type: 'text',
parameter_name: 'booking_code', parameter_name: 'booking_code',