eigen/trackgo-be
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Refactor code formatting for improved readability

Browse Source 
- Reformatted import statements and object properties across multiple files to enhance code clarity and maintainability.
- Ensured consistent indentation and line breaks in test specifications and service implementations, improving overall code structure.
This commit is contained in:
shancheas
2026-09-02 08:14:39 +07:00
parent 82e4a0cbf0
commit 7253dece8e
13 changed files with 76 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/database/timeline-footprints-table.ts
+7 -1
View File
@@ -1,4 +1,10 @@
import { bigint, doublePrecision, index, pgTable, uuid } from 'drizzle-orm/pg-core';
import {
bigint,
doublePrecision,
index,
pgTable,
uuid,
} from 'drizzle-orm/pg-core';
import { employees } from './employees-table';
export const timelineFootprints = pgTable(
src/modules/auth/auth.controller.spec.ts
+3 -1
View File
@@ -137,7 +137,9 @@ describe('AuthController', () => {
).resolves.toMatchObject({
privilege: { id: 'priv-1', code: 'ADMIN' },
permissions: {
'ADMIN.SETTINGS.USER.PRIVILEGES': expect.objectContaining({ view: true }),
'ADMIN.SETTINGS.USER.PRIVILEGES': expect.objectContaining({
view: true,
}),
},
});
});
src/modules/field/cycles/cycles.service.spec.ts
+4 -1
View File
@@ -34,7 +34,10 @@ describe('CyclesService', () => {
const employeesService = { findById: jest.fn(), findByCode: jest.fn() };
const branchesService = { findById: jest.fn(), findByCode: jest.fn() };
const customersService = { findById: jest.fn(), findByCode: jest.fn() };
const privilegesService = { checkPermission: jest.fn(), checkAnyPermission: jest.fn() };
const privilegesService = {
checkPermission: jest.fn(),
checkAnyPermission: jest.fn(),
};
const now = DateTime.fromUnixMs(1_700_000_000_000);
const user: AuthUser = {
src/modules/field/plans/plans.service.spec.ts
+4 -1
View File
@@ -72,7 +72,10 @@ describe('PlansService', () => {
markDraftsProcessed: jest.fn(),
};
const packingSlipsService = { findById: jest.fn() };
const privilegesService = { checkPermission: jest.fn(), checkAnyPermission: jest.fn() };
const privilegesService = {
checkPermission: jest.fn(),
checkAnyPermission: jest.fn(),
};
const user: AuthUser = {
id: 'user-1',
src/modules/field/timeline/timeline.service.spec.ts
+11 -3
View File
@@ -14,7 +14,9 @@ describe('TimelineService', () => {
let footprintsRepository: jest.Mocked<
Pick<TimelineFootprintsRepository, 'insertMany' | 'list'>
>;
let activitiesRepository: jest.Mocked<Pick<TimelineActivitiesRepository, 'list'>>;
let activitiesRepository: jest.Mocked<
Pick<TimelineActivitiesRepository, 'list'>
>;
let employeesService: jest.Mocked<Pick<EmployeesService, 'requireByUserId'>>;
let companySettingsService: jest.Mocked<
Pick<CompanySettingsService, 'requireTimelineConfig'>
@@ -40,8 +42,14 @@ describe('TimelineService', () => {
const moduleRef: TestingModule = await Test.createTestingModule({
providers: [
TimelineService,
{ provide: TimelineFootprintsRepository, useValue: footprintsRepository },
{ provide: TimelineActivitiesRepository, useValue: activitiesRepository },
{
provide: TimelineFootprintsRepository,
useValue: footprintsRepository,
},
{
provide: TimelineActivitiesRepository,
useValue: activitiesRepository,
},
{ provide: EmployeesService, useValue: employeesService },
{ provide: CompanySettingsService, useValue: companySettingsService },
],
src/modules/field/timeline/timeline.service.ts
+8 -8
View File
@@ -1,7 +1,4 @@
import {
BadRequestException,
Injectable,
} from '@nestjs/common';
import { BadRequestException, Injectable } from '@nestjs/common';
import {
DEFAULT_RELATION_FIELDS,
pickRelation,
@@ -138,14 +135,17 @@ export class TimelineService {
if (employeeId || footprints.length <= MAX_FOOTPRINTS_ALL_EMPLOYEES) {
return [...footprints];
}
const stride = Math.ceil(
footprints.length / MAX_FOOTPRINTS_ALL_EMPLOYEES,
);
const stride = Math.ceil(footprints.length / MAX_FOOTPRINTS_ALL_EMPLOYEES);
return footprints.filter((_, index) => index % stride === 0);
}
private assertCoordinates(latitude: number, longitude: number): void {
if (latitude < -90 || latitude > 90 || longitude < -180 || longitude > 180) {
if (
latitude < -90 ||
latitude > 90 ||
longitude < -180 ||
longitude > 180
) {
throw new BadRequestException('Invalid coordinates');
}
}
src/modules/privileges/privilege-action.spec.ts
+9 -3
View File
@@ -18,10 +18,16 @@ describe('privilege-action', () => {
describe('privilege-key-code', () => {
it('accepts 3- and 4-part dotted uppercase codes', () => {
expect(isValidPrivilegeKeyCode('ADMIN.SETTINGS.USER.PRIVILEGES')).toBe(true);
expect(isValidPrivilegeKeyCode('ADMIN.SALES.ACTIVITIES.INVOICE')).toBe(true);
expect(isValidPrivilegeKeyCode('ADMIN.SETTINGS.USER.PRIVILEGES')).toBe(
true,
);
expect(isValidPrivilegeKeyCode('ADMIN.SALES.ACTIVITIES.INVOICE')).toBe(
true,
);
expect(isValidPrivilegeKeyCode('MOBILE.SALES.PLAN')).toBe(true);
expect(assertPrivilegeKeyCode('MOBILE.SALES.PLAN')).toBe('MOBILE.SALES.PLAN');
expect(assertPrivilegeKeyCode('MOBILE.SALES.PLAN')).toBe(
'MOBILE.SALES.PLAN',
);
});
it('rejects invalid codes', () => {
src/modules/privileges/privilege-key-code.spec.ts
+6 -2
View File
@@ -12,7 +12,9 @@ describe('privilege-key-code', () => {
});
it('accepts 4-part keys', () => {
expect(isValidPrivilegeKeyCode('MOBILE.SALES.PLAN.ATTENDANCE')).toBe(true);
expect(isValidPrivilegeKeyCode('MOBILE.SALES.PLAN.ATTENDANCE')).toBe(
true,
);
expect(isValidPrivilegeKeyCode('ADMIN.SALES.ACTIVITIES.PLAN')).toBe(true);
});
@@ -33,7 +35,9 @@ describe('privilege-key-code', () => {
describe('assertPrivilegeKeyCode', () => {
it('returns the code when valid', () => {
expect(assertPrivilegeKeyCode('MOBILE.SALES.PLAN')).toBe('MOBILE.SALES.PLAN');
expect(assertPrivilegeKeyCode('MOBILE.SALES.PLAN')).toBe(
'MOBILE.SALES.PLAN',
);
});
it('throws when invalid', () => {
src/modules/privileges/privileges.service.spec.ts
+1 -5
View File
@@ -169,11 +169,7 @@ describe('PrivilegesService', () => {
it('checkAnyPermission uses checkPermission for a single key', async () => {
repository.checkPermission.mockResolvedValue(true);
await expect(
service.checkAnyPermission(
'user-1',
['MOBILE.SALES.PLAN'],
'view',
),
service.checkAnyPermission('user-1', ['MOBILE.SALES.PLAN'], 'view'),
).resolves.toBe(true);
expect(repository.checkPermission).toHaveBeenCalledWith(
'user-1',
src/modules/sales/packing-slips/packing-slips-read.controller.ts
+2 -1
View File
@@ -21,7 +21,8 @@ import {
} from './dto/packing-slip.dto';
import { PackingSlipsService } from './packing-slips.service';
export const PACKING_SLIP_PRIVILEGE_KEY = 'ADMIN.LOGISTICS.ACTIVITIES.PACKING_SLIP';
export const PACKING_SLIP_PRIVILEGE_KEY =
'ADMIN.LOGISTICS.ACTIVITIES.PACKING_SLIP';
@ApiTags('packing-slips')
@ApiBearerAuth(BEARER_AUTH_NAME)
test/company-settings.e2e-spec.ts
+3 -3
View File
@@ -118,9 +118,9 @@ describe('Company settings (e2e)', () => {
})
.expect(200);
expect((updated.body as { gpsIntervalSeconds: number }).gpsIntervalSeconds).toBe(
15,
);
expect(
(updated.body as { gpsIntervalSeconds: number }).gpsIntervalSeconds,
).toBe(15);
expect(
(updated.body as { checkoutWarningRadiusMeters: number })
.checkoutWarningRadiusMeters,
test/privileges.e2e-spec.ts
+3 -1
View File
@@ -202,7 +202,9 @@ describe('Privileges (e2e)', () => {
expect(me.body.privilege).toMatchObject({
id: adminPrivilegeId,
});
expect(me.body.permissions['ADMIN.SETTINGS.USER.PRIVILEGES'].view).toBe(true);
expect(me.body.permissions['ADMIN.SETTINGS.USER.PRIVILEGES'].view).toBe(
true,
);
await request(app.getHttpServer())
.patch(`/users/${otherUserId}/privilege`)
test/timeline.e2e-spec.ts
+15 -4
View File
@@ -135,7 +135,8 @@ describe('Timeline (e2e)', () => {
});
it('ingests footprints and returns them on admin timeline query', async () => {
const recordedAt = DateTime.fromUnixMs(Date.now()).startOfDay().value + 3_600_000;
const recordedAt =
DateTime.fromUnixMs(Date.now()).startOfDay().value + 3_600_000;
const ingest = await request(app.getHttpServer())
.post('/timeline/footprints')
@@ -143,14 +144,21 @@ describe('Timeline (e2e)', () => {
.send({
points: [
{ latitude: -6.2, longitude: 106.8, recordedAt },
{ latitude: -6.201, longitude: 106.801, recordedAt: recordedAt + 5000 },
{
latitude: -6.201,
longitude: 106.801,
recordedAt: recordedAt + 5000,
},
],
})
.expect(201);
expect((ingest.body as { inserted: number }).inserted).toBe(2);
const today = DateTime.fromUnixMs(Date.now()).startOfDay().format().slice(0, 10);
const today = DateTime.fromUnixMs(Date.now())
.startOfDay()
.format()
.slice(0, 10);
const day = await request(app.getHttpServer())
.get('/timeline')
.query({ date: today, employeeId })
@@ -168,7 +176,10 @@ describe('Timeline (e2e)', () => {
});
it('returns activities-only timeline for the current user', async () => {
const today = DateTime.fromUnixMs(Date.now()).startOfDay().format().slice(0, 10);
const today = DateTime.fromUnixMs(Date.now())
.startOfDay()
.format()
.slice(0, 10);
const me = await request(app.getHttpServer())
.get('/timeline/me')
.query({ date: today })