From f2cff7699ae6e48a8044dbb9ba8b13637bd3cc1d Mon Sep 17 00:00:00 2001 From: Firman Ramdhani <33869609+firmanramdhani@users.noreply.github.com> Date: Mon, 20 Jul 2026 14:18:33 +0700 Subject: [PATCH] fix: update cSpell.words in settings.json and improve code formatting in various files --- .vscode/settings.json | 2 +- .../full-page/presentation/factory/index.tsx | 4 ++-- .../data-services/base-data.transformer.ts | 13 ++++-------- .../providers/module.provider.tsx | 21 ++++++++++++------- 4 files changed, 21 insertions(+), 19 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index 1b53be8..16bfb9c 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -4,5 +4,5 @@ "mode": "auto" } ], - "cSpell.words": ["mantine", "Menlo", "mgmt", "Millis", "Pandang", "Segoe", "Ujung", "VITE", "WITA"] + "cSpell.words": ["dtos", "mantine", "Menlo", "mgmt", "Millis", "Pandang", "Segoe", "TDTO", "Ujung", "VITE", "WITA"] } diff --git a/apps/web/src/apps/modules/example/full-page/presentation/factory/index.tsx b/apps/web/src/apps/modules/example/full-page/presentation/factory/index.tsx index f0bcf71..a1415d8 100644 --- a/apps/web/src/apps/modules/example/full-page/presentation/factory/index.tsx +++ b/apps/web/src/apps/modules/example/full-page/presentation/factory/index.tsx @@ -29,8 +29,8 @@ registerModuleNamespace(fullPageModuleConfig.translationNamespace, { // --------------------------------------------------------------------------- export default function FullPageModule() { return ( - - config={fullPageModuleConfig} + + config={fullPageModuleConfig} dataServices={fullPageDataService} store={fullPageStore} > diff --git a/packages/core-api/src/data-services/base-data.transformer.ts b/packages/core-api/src/data-services/base-data.transformer.ts index 58dfc53..c07974b 100644 --- a/packages/core-api/src/data-services/base-data.transformer.ts +++ b/packages/core-api/src/data-services/base-data.transformer.ts @@ -25,10 +25,7 @@ import type { BaseEntity } from './types'; * } * ``` */ -export interface IDataTransformer< - TEntity extends BaseEntity = BaseEntity, - TDTO = TEntity, -> { +export interface IDataTransformer { /** * Transform an API DTO into a domain entity. * @@ -88,7 +85,7 @@ export interface IDataTransformer< * * Extends the core `IDataTransformer` contract with granular hooks * for each CRUD operation. Override only the hooks you need — - * unoverridden hooks delegate to the core `transformToEntity` / + * un overridden hooks delegate to the core `transformToEntity` / * `transformToDTO` methods. * * **Design rationale (from legacy analysis):** @@ -129,10 +126,8 @@ export interface IDataTransformer< * } * ``` */ -export abstract class BaseDataTransformer< - TEntity extends BaseEntity = BaseEntity, - TDTO = TEntity, -> implements IDataTransformer +export abstract class BaseDataTransformer + implements IDataTransformer { /** * Core DTO → Entity transformation. diff --git a/packages/ui/src/foundations/enterprise-module/providers/module.provider.tsx b/packages/ui/src/foundations/enterprise-module/providers/module.provider.tsx index b54bc9c..aafcb66 100644 --- a/packages/ui/src/foundations/enterprise-module/providers/module.provider.tsx +++ b/packages/ui/src/foundations/enterprise-module/providers/module.provider.tsx @@ -3,7 +3,14 @@ import type { UseBoundStore, StoreApi } from 'zustand'; import { useNavigate } from 'react-router-dom'; import { useTranslation } from '@repo/core-i18n'; import { BaseEntity, BaseRemoteDataServices } from '@repo/core-api/data-services'; -import { ConfigSlice, ModuleConfigEntity, SinglePageFormState, SinglePageModalState, EnterpriseModuleState, PrivilegeEntity } from '../entities/entity'; +import { + ConfigSlice, + ModuleConfigEntity, + SinglePageFormState, + SinglePageModalState, + EnterpriseModuleState, + PrivilegeEntity, +} from '../entities/entity'; import { EnterpriseConfigContext, EnterpriseDataServiceContext, @@ -17,7 +24,7 @@ import { Forbidden } from '../../../components'; export interface EnterpriseModuleProviderProps< E extends BaseEntity, - S extends EnterpriseModuleState = EnterpriseModuleState + S extends EnterpriseModuleState = EnterpriseModuleState, > { children: ReactNode; config: ModuleConfigEntity; @@ -30,7 +37,7 @@ const IS_MACOS = typeof navigator !== 'undefined' && /Mac|iPod|iPhone|iPad/.test export function EnterpriseModuleProvider< E extends BaseEntity, - S extends EnterpriseModuleState = EnterpriseModuleState + S extends EnterpriseModuleState = EnterpriseModuleState, >(props: EnterpriseModuleProviderProps) { const { children, config, dataServices, store } = props; const navigate = useNavigate(); @@ -38,12 +45,12 @@ export function EnterpriseModuleProvider< // --------------------------------------------------------------------------- // 1. Config Slice (Static) // --------------------------------------------------------------------------- - + const storePrivileges = store((state: S) => state.privileges); - + const configSlice: ConfigSlice = useMemo(() => { - // FIXME => Parsing privilege: mapping string array dari store ke format PrivilegeEntity (boolean) - const parsedPrivileges = defaultPrivileges + // Parsing privilege: mapping string array from store to PrivilegeEntity format (boolean) + const parsedPrivileges: PrivilegeEntity = defaultPrivileges; return { config,