external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Refactor AppendAlterTableCmdAddConstraint to reuse it for ADD COLUMN too

pull/7032/head
Onur Tirtir 2023-06-22 18:28:54 +03:00
parent 56f1daa800
commit 001437bdfe
1 changed files with 30 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
src/backend/distributed/deparser/deparse_table_stmts.c
View File

@ -142,13 +142,19 @@ AppendColumnNameList(StringInfo buf, List *columns)
/* /*
* AppendAlterTableCmdAddConstraint builds the add constraint command for index constraints * AppendAlterTableCmdConstraint builds a string required to create given
* in the ADD CONSTRAINT <conname> {PRIMARY KEY, UNIQUE, EXCLUSION} form and appends it to the buf. * constraint as part of an ADD CONSTRAINT subcommand and appends it to
* the buf.
*/ */
static void static void
AppendAlterTableCmdAddConstraint(StringInfo buf, Constraint *constraint, AppendAlterTableCmdConstraint(StringInfo buf, Constraint *constraint,
AlterTableStmt *stmt) AlterTableStmt *stmt, AlterTableType subtype)
{ {
if (subtype != AT_AddConstraint)
{
ereport(ERROR, (errmsg("Unsupported alter table subtype: %d", (int) subtype)));
}
/* Need to deparse the alter table constraint command only if we are adding a constraint name.*/ /* Need to deparse the alter table constraint command only if we are adding a constraint name.*/
if (constraint->conname == NULL) if (constraint->conname == NULL)
{ {
@ -156,7 +162,11 @@ AppendAlterTableCmdAddConstraint(StringInfo buf, Constraint *constraint,
"Constraint name can not be NULL when deparsing the constraint."))); "Constraint name can not be NULL when deparsing the constraint.")));
} }
appendStringInfoString(buf, " ADD CONSTRAINT "); if (subtype == AT_AddConstraint)
{
appendStringInfoString(buf, " ADD CONSTRAINT ");
}
appendStringInfo(buf, "%s ", quote_identifier(constraint->conname)); appendStringInfo(buf, "%s ", quote_identifier(constraint->conname));
/* postgres version >= PG15 /* postgres version >= PG15
@ -184,7 +194,10 @@ AppendAlterTableCmdAddConstraint(StringInfo buf, Constraint *constraint,
#endif #endif
} }
AppendColumnNameList(buf, constraint->keys); if (subtype == AT_AddConstraint)
{
AppendColumnNameList(buf, constraint->keys);
}
if (constraint->including != NULL) if (constraint->including != NULL)
{ {
@ -275,9 +288,12 @@ AppendAlterTableCmdAddConstraint(StringInfo buf, Constraint *constraint,
} }
else if (constraint->contype == CONSTR_FOREIGN) else if (constraint->contype == CONSTR_FOREIGN)
{ {
appendStringInfoString(buf, " FOREIGN KEY"); if (subtype == AT_AddConstraint)
{
appendStringInfoString(buf, " FOREIGN KEY");
AppendColumnNameList(buf, constraint->fk_attrs); AppendColumnNameList(buf, constraint->fk_attrs);
}
appendStringInfoString(buf, " REFERENCES"); appendStringInfoString(buf, " REFERENCES");
@ -379,8 +395,11 @@ AppendAlterTableCmdAddConstraint(StringInfo buf, Constraint *constraint,
} }
} }
/* FOREIGN KEY and CHECK constraints migth have NOT VALID option */ /*
if (constraint->skip_validation) * For ADD CONSTRAINT subcommand, FOREIGN KEY and CHECK constraints migth
* have NOT VALID option.
*/
if (subtype == AT_AddConstraint && constraint->skip_validation)
{ {
appendStringInfoString(buf, " NOT VALID "); appendStringInfoString(buf, " NOT VALID ");
} }
@ -429,7 +448,7 @@ AppendAlterTableCmd(StringInfo buf, AlterTableCmd *alterTableCmd, AlterTableStmt
*/ */
if (ConstrTypeCitusCanDefaultName(constraint->contype)) if (ConstrTypeCitusCanDefaultName(constraint->contype))
{ {
AppendAlterTableCmdAddConstraint(buf, constraint, stmt); AppendAlterTableCmdConstraint(buf, constraint, stmt, AT_AddConstraint);
break; break;
} }
} }