external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Adress reviews

velioglu/wo_seq_test_1
Burak Velioglu 2022-01-16 16:39:49 +03:00
parent 5e2e5c3470
commit 04511cc5e0
No known key found for this signature in database
GPG Key ID: F6827E620F6549C6
3 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/distributed/metadata/metadata_sync.c
View File

@ -158,18 +158,18 @@ start_metadata_sync_to_node(PG_FUNCTION_ARGS)
char *nodeNameString = text_to_cstring(nodeName);
StartMetadataSyncToNode(nodeNameString, nodePort);
SyncNodeMetadataToNode(nodeNameString, nodePort);
PG_RETURN_VOID();
}
/*
* StartMetadataSyncToNode is the internal API for
* SyncNodeMetadataToNode is the internal API for
* start_metadata_sync_to_node().
*/
void
StartMetadataSyncToNode(const char *nodeNameString, int32 nodePort)
SyncNodeMetadataToNode(const char *nodeNameString, int32 nodePort)
{
char *escapedNodeName = quote_literal_cstr(nodeNameString);

20
src/backend/distributed/metadata/node_metadata.c
View File

@ -651,9 +651,12 @@ SetUpMultipleDistributedTableIntegrations(WorkerNode *workerNode)
multipleTableIntegrationCommandList);
multipleTableIntegrationCommandList = lappend(multipleTableIntegrationCommandList,
ENABLE_DDL_PROPAGATION);
/* send commands to new workers, the current user should be a superuser */
Assert(superuser());
SendMetadataCommandListToWorkerInCoordinatedTransaction(workerNode->workerName,
workerNode->workerPort,
CitusExtensionOwnerName(),
CurrentUserName(),
multipleTableIntegrationCommandList);
}
@ -720,10 +723,11 @@ SetUpObjectMetadata(WorkerNode *workerNode)
metadataSnapshotCommandList = lappend(metadataSnapshotCommandList,
ENABLE_DDL_PROPAGATION);
char *currentUser = CurrentUserName();
/* send commands to new workers, the current user should be a superuser */
Assert(superuser());
SendMetadataCommandListToWorkerInCoordinatedTransaction(workerNode->workerName,
workerNode->workerPort,
currentUser,
CurrentUserName(),
metadataSnapshotCommandList);
}
@ -828,9 +832,11 @@ UpdatePgDistLocalGroupOnNode(WorkerNode *workerNode)
List *localGroupIdUpdateCommandList = list_make1(localGroupIdUpdateCommand);
/* send commands to new workers, the current user should be a superuser */
Assert(superuser());
SendMetadataCommandListToWorkerInCoordinatedTransaction(workerNode->workerName,
workerNode->workerPort,
CitusExtensionOwnerName(),
CurrentUserName(),
localGroupIdUpdateCommandList);
}
@ -857,9 +863,11 @@ ClearDistributedTablesFromNode(WorkerNode *workerNode)
list_make1(
ENABLE_DDL_PROPAGATION));
/* send commands to new workers, the current user should be a superuser */
Assert(superuser());
SendMetadataCommandListToWorkerInCoordinatedTransaction(workerNode->workerName,
workerNode->workerPort,
CitusExtensionOwnerName(),
CurrentUserName(),
clearDistributedTablesCommandList);
}
@ -1242,7 +1250,7 @@ ActivateNode(char *nodeName, int nodePort)
if (syncMetadata)
{
StartMetadataSyncToNode(nodeName, nodePort);
SyncNodeMetadataToNode(nodeName, nodePort);
if (!NodeIsCoordinator(workerNode))
{

2
src/include/distributed/metadata_sync.h
View File

@ -28,7 +28,7 @@ typedef enum
} MetadataSyncResult;
/* Functions declarations for metadata syncing */
extern void StartMetadataSyncToNode(const char *nodeNameString, int32 nodePort);
extern void SyncNodeMetadataToNode(const char *nodeNameString, int32 nodePort);
extern bool ClusterHasKnownMetadataWorkers(void);
extern char * LocalGroupIdUpdateCommand(int32 groupId);
extern bool ShouldSyncTableMetadata(Oid relationId);