Fixes review notes

pull/7404/head
gurkanindibay 2024-02-07 14:12:09 +03:00
parent 94450cd391
commit 0466f60244
1 changed files with 9 additions and 9 deletions

View File

@ -155,9 +155,9 @@ static bool IsDropSchemaOrDB(Node *parsetree);
static bool ShouldCheckUndistributeCitusLocalTables(void); static bool ShouldCheckUndistributeCitusLocalTables(void);
static void RunPreprocessMainDBCommand(Node *parsetree, const char *queryString); static void RunPreprocessMainDBCommand(Node *parsetree, const char *queryString);
static void RunPostprocessMainDBCommand(Node *parsetree); static void RunPostprocessMainDBCommand(Node *parsetree);
static bool IsStatementSupportedInNonMainDb(Node *parsetree); static bool IsStatementSupportedFromNonMainDb(Node *parsetree);
static bool StatementRequiresMarkDistributedFromNonMainDb(Node *parsetree); static bool StatementRequiresMarkDistributedFromNonMainDb(Node *parsetree);
static void MarkObjectDistributedInNonMainDb(Node *parsetree); static void MarkObjectDistributedOnNonMainDb(Node *parsetree);
static ObjectInfo GetObjectInfo(Node *parsetree); static ObjectInfo GetObjectInfo(Node *parsetree);
/* /*
@ -1638,7 +1638,7 @@ DropSchemaOrDBInProgress(void)
static void static void
RunPreprocessMainDBCommand(Node *parsetree, const char *queryString) RunPreprocessMainDBCommand(Node *parsetree, const char *queryString)
{ {
if (!IsStatementSupportedInNonMainDb(parsetree)) if (!IsStatementSupportedFromNonMainDb(parsetree))
{ {
return; return;
} }
@ -1664,20 +1664,20 @@ RunPreprocessMainDBCommand(Node *parsetree, const char *queryString)
static void static void
RunPostprocessMainDBCommand(Node *parsetree) RunPostprocessMainDBCommand(Node *parsetree)
{ {
if (IsStatementSupportedInNonMainDb(parsetree) && if (IsStatementSupportedFromNonMainDb(parsetree) &&
StatementRequiresMarkDistributedFromNonMainDb(parsetree)) StatementRequiresMarkDistributedFromNonMainDb(parsetree))
{ {
MarkObjectDistributedInNonMainDb(parsetree); MarkObjectDistributedOnNonMainDb(parsetree);
} }
} }
/* /*
* IsStatementSupportedInNonMainDb returns true if the statement is supported from a * IsStatementSupportedFromNonMainDb returns true if the statement is supported from a
* non-main database. * non-main database.
*/ */
static bool static bool
IsStatementSupportedInNonMainDb(Node *parsetree) IsStatementSupportedFromNonMainDb(Node *parsetree)
{ {
NodeTag type = nodeTag(parsetree); NodeTag type = nodeTag(parsetree);
@ -1717,11 +1717,11 @@ StatementRequiresMarkDistributedFromNonMainDb(Node *parsetree)
/* /*
* MarkObjectDistributedInNonMainDb marks the given object as distributed on the * MarkObjectDistributedOnNonMainDb marks the given object as distributed on the
* non-main database. * non-main database.
*/ */
static void static void
MarkObjectDistributedInNonMainDb(Node *parsetree) MarkObjectDistributedOnNonMainDb(Node *parsetree)
{ {
ObjectInfo objectInfo = GetObjectInfo(parsetree); ObjectInfo objectInfo = GetObjectInfo(parsetree);
StringInfo mainDBQuery = makeStringInfo(); StringInfo mainDBQuery = makeStringInfo();