From 082a14656d1203eaba761593a36429185b6c1920 Mon Sep 17 00:00:00 2001 From: Marco Slot Date: Fri, 13 May 2022 11:46:42 +0200 Subject: [PATCH] Fix downgrade scripts and add new downgrade tests --- .../distributed/sql/downgrades/citus--11.0-2--11.0-1.sql | 1 + src/test/regress/expected/multi_extension.out | 8 ++++++++ src/test/regress/sql/multi_extension.sql | 5 +++++ 3 files changed, 14 insertions(+) diff --git a/src/backend/distributed/sql/downgrades/citus--11.0-2--11.0-1.sql b/src/backend/distributed/sql/downgrades/citus--11.0-2--11.0-1.sql index fca765ba7..387d768b0 100644 --- a/src/backend/distributed/sql/downgrades/citus--11.0-2--11.0-1.sql +++ b/src/backend/distributed/sql/downgrades/citus--11.0-2--11.0-1.sql @@ -1,2 +1,3 @@ #include "../udfs/citus_shards_on_worker/11.0-1.sql" #include "../udfs/citus_shard_indexes_on_worker/11.0-1.sql" +DROP FUNCTION pg_catalog.citus_is_coordinator(); diff --git a/src/test/regress/expected/multi_extension.out b/src/test/regress/expected/multi_extension.out index 876b557dc..6b092d73a 100644 --- a/src/test/regress/expected/multi_extension.out +++ b/src/test/regress/expected/multi_extension.out @@ -1039,6 +1039,14 @@ SELECT * FROM multi_extension.print_extension_changes(); | function citus_is_coordinator() boolean (1 row) +-- Test downgrade script (result should be empty) +ALTER EXTENSION citus UPDATE TO '11.0-1'; +ALTER EXTENSION citus UPDATE TO '11.0-2'; +SELECT * FROM multi_extension.print_extension_changes(); + previous_object | current_object +--------------------------------------------------------------------- +(0 rows) + DROP TABLE multi_extension.prev_objects, multi_extension.extension_diff; -- show running version SHOW citus.version; diff --git a/src/test/regress/sql/multi_extension.sql b/src/test/regress/sql/multi_extension.sql index 7cbe0ab2f..2701455de 100644 --- a/src/test/regress/sql/multi_extension.sql +++ b/src/test/regress/sql/multi_extension.sql @@ -463,6 +463,11 @@ SELECT * FROM multi_extension.print_extension_changes(); ALTER EXTENSION citus UPDATE TO '11.0-2'; SELECT * FROM multi_extension.print_extension_changes(); +-- Test downgrade script (result should be empty) +ALTER EXTENSION citus UPDATE TO '11.0-1'; +ALTER EXTENSION citus UPDATE TO '11.0-2'; +SELECT * FROM multi_extension.print_extension_changes(); + DROP TABLE multi_extension.prev_objects, multi_extension.extension_diff; -- show running version