external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix bug in unqualified, non-existing DROP DOMAIN IF EXISTS 

(cherry picked from commit ee34e1ed9d)
release_11_15_june_onder_2
Marco Slot 2022-06-15 13:59:08 +02:00 committed by Onder Kalaci
parent de6373b842
commit 0861c80c8b
3 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/distributed/deparser/qualify_domain.c
View File

@ -205,10 +205,13 @@ QualifyTypeName(TypeName *typeName, bool missing_ok)
if (!schemaName) if (!schemaName)
{ {
Oid typeOid = LookupTypeNameOid(NULL, typeName, missing_ok); Oid typeOid = LookupTypeNameOid(NULL, typeName, missing_ok);
Oid namespaceOid = TypeOidGetNamespaceOid(typeOid); if (OidIsValid(typeOid))
schemaName = get_namespace_name(namespaceOid); {
Oid namespaceOid = TypeOidGetNamespaceOid(typeOid);
schemaName = get_namespace_name(namespaceOid);
typeName->names = list_make2(makeString(schemaName), makeString(name)); typeName->names = list_make2(makeString(schemaName), makeString(name));
}
} }
} }
} }

2
src/test/regress/expected/distributed_domain.out
View File

@ -943,5 +943,7 @@ SELECT * FROM run_command_on_workers($$ SELECT '1'::distributed_domain.domain3;
localhost | 57638 | f | ERROR: type "distributed_domain.domain3" does not exist localhost | 57638 | f | ERROR: type "distributed_domain.domain3" does not exist
(2 rows) (2 rows)
DROP DOMAIN IF EXISTS domain_does_not_exist;
NOTICE: type "domain_does_not_exist" does not exist, skipping
SET client_min_messages TO warning; SET client_min_messages TO warning;
DROP SCHEMA distributed_domain, distributed_domain_moved CASCADE; DROP SCHEMA distributed_domain, distributed_domain_moved CASCADE;

2
src/test/regress/sql/distributed_domain.sql
View File

@ -483,5 +483,7 @@ SELECT * FROM run_command_on_workers($$ SELECT 1::distributed_domain.domain1; $$
SELECT * FROM run_command_on_workers($$ SELECT '1'::distributed_domain.domain2; $$) ORDER BY 1,2; SELECT * FROM run_command_on_workers($$ SELECT '1'::distributed_domain.domain2; $$) ORDER BY 1,2;
SELECT * FROM run_command_on_workers($$ SELECT '1'::distributed_domain.domain3; $$) ORDER BY 1,2; SELECT * FROM run_command_on_workers($$ SELECT '1'::distributed_domain.domain3; $$) ORDER BY 1,2;
DROP DOMAIN IF EXISTS domain_does_not_exist;
SET client_min_messages TO warning; SET client_min_messages TO warning;
DROP SCHEMA distributed_domain, distributed_domain_moved CASCADE; DROP SCHEMA distributed_domain, distributed_domain_moved CASCADE;