Cleanup

.github/actions/configure/action.yml

@@ -1,10 +0,0 @@
-name: configure
-runs:
-  using: composite
-  steps:
-  - name: Configure
-    run: |-
-      chown -R circleci .
-      git config --global --add safe.directory ${GITHUB_WORKSPACE}
-      gosu circleci ./configure --without-pg-version-check
-    shell: bash

.github/actions/enable_core/action.yml

@@ -1,7 +0,0 @@
-name: enable_core
-runs:
-  using: composite
-  steps:
-  - name: Enable core dumps
-    run: ulimit -c unlimited
-    shell: bash

.github/actions/install_extension/action.yml

@@ -5,3 +5,12 @@ runs:
   - name: Install Extension
     run: tar xfv "install-$PG_MAJOR.tar" --directory /
     shell: bash
+  - name: Configure
+    run: |-
+      chown -R circleci .
+      git config --global --add safe.directory ${GITHUB_WORKSPACE}
+      gosu circleci ./configure --without-pg-version-check
+    shell: bash
+  - name: Enable core dumps
+    run: ulimit -c unlimited
+    shell: bash

.github/actions/save_logs_and_results/action.yml

@@ -7,6 +7,7 @@ runs:
   using: composite
   steps:
   - uses: actions/upload-artifact@v3.1.1
+    name: Upload logs
     with:
       name: ${{ inputs.folder }}
       if-no-files-found: ignore
@@ -16,3 +17,16 @@ runs:
         src/test/**/tmp_check/master/log
         src/test/**/tmp_check/worker.57638/log
         src/test/**/tmp_check/worker.57637/log
+        src/test/**/regression.diffs
+  - name: Publish regression.diffs
+    run: |-
+      if [ -f "src/test/regress/regression.diffs" ]; then
+        echo "```diff" >> $GITHUB_STEP_SUMMARY
+        cat src/test/regress/regression.diffs >> $GITHUB_STEP_SUMMARY
+        echo "```" >> $GITHUB_STEP_SUMMARY
+      fi
+    shell: bash
+  - name: Print stack traces
+    run: "./ci/print_stack_trace.sh"
+    if: failure()
+    shell: bash

.github/actions/save_regressions/action.yml

@@ -1,22 +0,0 @@
-name: save_regressions
-inputs:
-  folder:
-    required: false
-    default: "log"
-runs:
-  using: composite
-  steps:
-  - name: Regressions
-    run: |-
-      if [ -f "src/test/regress/regression.diffs" ]; then
-        echo "```diff" >> $GITHUB_STEP_SUMMARY
-        cat src/test/regress/regression.diffs >> $GITHUB_STEP_SUMMARY
-        echo "```" >> $GITHUB_STEP_SUMMARY
-      fi
-    shell: bash
-  - uses: actions/upload-artifact@v3.1.1
-    with:
-      path: ${GITHUB_WORKSPACE}/**/regression.diffs
-      name: ${{ inputs.folder }}
-      if-no-files-found: ignore
-

.github/actions/stack_trace/action.yml

@@ -1,8 +0,0 @@
-name: stack_trace
-runs:
-  using: composite
-  steps:
-  - name: Print stack traces
-    run: "./ci/print_stack_trace.sh"
-    if: failure()
-    shell: bash

.github/workflows/build_and_test.yml

@@ -187,8 +187,6 @@ jobs:
       with:
         name: build-${{ env.PG_MAJOR }}
     - uses: "./.github/actions/install_extension"
-    - uses: "./.github/actions/configure"
-    - uses: "./.github/actions/enable_core"
     - name: Run Test
       run: gosu circleci make -C src/test/${{ matrix.suite }} ${{ matrix.make }}
       timeout-minutes: 20
@@ -196,12 +194,6 @@ jobs:
       if: always()
       with:
         folder: ${{ matrix.pg_version }}_${{ matrix.make }}
-    - uses: "./.github/actions/save_regressions"
-      if: always()
-      with:
-          folder: ${{ matrix.pg_version }}_${{ matrix.make }}
-    - uses: "./.github/actions/stack_trace"
-      if: always()
     - uses: "./.github/actions/upload_coverage"
       if: always()
       with:

.github/workflows/flaky_test_debugging.yml

@@ -112,8 +112,6 @@ jobs:
         fi
         echo "tests=$tests" >> "$GITHUB_OUTPUT"
     - uses: "./.github/actions/install_extension"
-    - uses: "./.github/actions/configure"
-    - uses: "./.github/actions/enable_core"
     - name: Run minimal tests
       run: |-
         tests_array=(${{ steps.detect-regression-tests.outputs.tests }})