Minor refactorings

issue/6694
Gokhan Gulbiz 2023-02-28 15:31:01 +03:00
parent 9e45f8c6b7
commit 08bf877d29
No known key found for this signature in database
GPG Key ID: 608EF06B6BD1B45B
1 changed files with 7 additions and 4 deletions

View File

@ -161,7 +161,7 @@ static void EnsureColocateWithTableIsValid(Oid relationId, char distributionMeth
char *distributionColumnName, char *distributionColumnName,
char *colocateWithTableName); char *colocateWithTableName);
static void WarnIfTableHaveNoReplicaIdentity(Oid relationId); static void WarnIfTableHaveNoReplicaIdentity(Oid relationId);
static void MarkIdentitiesAsDistributed(Oid targetRelationId); static void DistributeIdentityColumns(Oid targetRelationId);
/* exports for SQL callable functions */ /* exports for SQL callable functions */
PG_FUNCTION_INFO_V1(master_create_distributed_table); PG_FUNCTION_INFO_V1(master_create_distributed_table);
@ -1165,7 +1165,7 @@ CreateDistributedTable(Oid relationId, char *distributionColumnName,
ExecuteForeignKeyCreateCommandList(originalForeignKeyRecreationCommands, ExecuteForeignKeyCreateCommandList(originalForeignKeyRecreationCommands,
skip_validation); skip_validation);
MarkIdentitiesAsDistributed(relationId); DistributeIdentityColumns(relationId);
} }
@ -1806,10 +1806,13 @@ ErrorIfTableIsACatalogTable(Relation relation)
/* /*
* This function marks all the identity sequences as distributed on the given table. * DistributeIdentityColumns is responsible for marking sequences depend on
* identity columns of a given table. If the table has any identity columns,
* this function executes a command on workers to modify the identity columns
* min/max values to produce unique values on workers.
*/ */
static void static void
MarkIdentitiesAsDistributed(Oid targetRelationId) DistributeIdentityColumns(Oid targetRelationId)
{ {
Relation relation = relation_open(targetRelationId, AccessShareLock); Relation relation = relation_open(targetRelationId, AccessShareLock);
TupleDesc tupleDescriptor = RelationGetDescr(relation); TupleDesc tupleDescriptor = RelationGetDescr(relation);