external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve comments

use-plancontext-more
Jelte Fennema 2020-01-03 10:37:10 +01:00
parent 53020a7439
commit 093be287e2
1 changed files with 11 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/backend/distributed/planner/distributed_planner.c
View File

@ -73,8 +73,10 @@ typedef struct DistributedPlanningContext
Query *parse; Query *parse;
/* A copy of the original parsed query that is given to the planner. This /* A copy of the original parsed query that is given to the planner. This
* doesn't contain the changes that are made to parse. This is NULL for non * doesn't contain most of the changes that are made to parse. There's one
* distributed plans, since those don't need it. */ * that change that is made for non fast path router queries though, which
* is the assigning of RTE identities using AssignRTEIdentities. This is
* NULL for non distributed plans, since those don't need it. */
Query *originalQuery; Query *originalQuery;
/* the cursor options given to the planner */ /* the cursor options given to the planner */
@ -194,7 +196,9 @@ distributed_planner(Query *parse, int cursorOptions, ParamListInfo boundParams)
{ {
/* /*
* We need to copy the parse tree because the FastPathPlanner modifies * We need to copy the parse tree because the FastPathPlanner modifies
* it. * it. In the next branch we do the same for other distributed queries
* too, but for those it needs to be done AFTER calling
* AssignRTEIdentities.
*/ */
ctx.originalQuery = copyObject(parse); ctx.originalQuery = copyObject(parse);
} }
@ -217,10 +221,9 @@ distributed_planner(Query *parse, int cursorOptions, ParamListInfo boundParams)
/* /*
* standard_planner scribbles on it's input, but for deparsing we need the * standard_planner scribbles on it's input, but for deparsing we need the
* unmodified form. Note that we keep RTE_RELATIONs with their identities * unmodified form. Note that before copying we call
* set, which doesn't break our goals, but, prevents us keeping an extra copy * AssignRTEIdentities, which is needed because these identities need
* of the query tree. Note that we copy the query tree once we're sure it's a * to be present in the copied query too.
* distributed query.
*/ */
rteIdCounter = AssignRTEIdentities(rangeTableList, rteIdCounter); rteIdCounter = AssignRTEIdentities(rangeTableList, rteIdCounter);
ctx.originalQuery = copyObject(parse); ctx.originalQuery = copyObject(parse);
@ -250,16 +253,9 @@ distributed_planner(Query *parse, int cursorOptions, ParamListInfo boundParams)
PG_TRY(); PG_TRY();
{ {
/*
* For trivial queries, we're skipping the standard_planner() in
* order to eliminate its overhead.
*
* Otherwise, call into standard planner. This is required because the Citus
* planner relies on both the restriction information per table and parse tree
* transformations made by postgres' planner.
*/
DistributedPlan *delegatedPlan = NULL; DistributedPlan *delegatedPlan = NULL;
bool hasExternParam = false; bool hasExternParam = false;
if (fastPathRouterQuery) if (fastPathRouterQuery)
{ {
result = PlanFastPathDistributedStmt(&ctx, distributionKeyValue); result = PlanFastPathDistributedStmt(&ctx, distributionKeyValue);