external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Refactor handling of RTE_GROUP in get_name_for_var_field to clarify unreachable code

pull/8010/head
Mehmet Yilmaz 2025-06-19 13:42:37 +00:00
parent 6280c94f7a
commit 0d4e116d82
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/backend/distributed/deparser/ruleutils_18.c
View File

@ -4853,14 +4853,6 @@ get_name_for_var_field(Var *var, int fieldno,
case RTE_VALUES: case RTE_VALUES:
case RTE_NAMEDTUPLESTORE: case RTE_NAMEDTUPLESTORE:
case RTE_RESULT: case RTE_RESULT:
case RTE_GROUP:
/*
* This case should not occur: a column of a table or values list
* shouldn't have type RECORD. Fall through and fail (most
* likely) at the bottom.
*/
break;
case RTE_SUBQUERY: case RTE_SUBQUERY:
/* Subselect-in-FROM: examine sub-select's output expr */ /* Subselect-in-FROM: examine sub-select's output expr */
{ {
@ -5082,6 +5074,14 @@ get_name_for_var_field(Var *var, int fieldno,
} }
} }
break; break;
case RTE_GROUP:
/*
* We couldn't get here: any Vars that reference the RTE_GROUP RTE
* should have been replaced with the underlying grouping
* expressions.
*/
break;
} }
/* /*