external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix flaky multi_reference_table test (#6664) 

Sometimes in CI our multi_reference_table test fails like this:
```diff
 WHERE
 	colocated_table_test.value_2 = reference_table_test.value_2;
 LOG:  join order: [ "colocated_table_test" ][ reference join "reference_table_test" ]
  value_2
 ---------
-       1
        2
+       1
 (2 rows)
```
Source:
https://app.circleci.com/pipelines/github/citusdata/citus/30223/workflows/ce3ab5db-310f-4e30-ba0b-c3b31927d9b6/jobs/970041

We forgot an ORDER BY in this test.
pull/6666/head
Jelte Fennema 2023-01-30 13:32:38 +01:00 committed by GitHub
parent ab71cd01ee
commit 10603ed5d4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/test/regress/expected/multi_reference_table.out
View File

@ -1020,7 +1020,8 @@ SELECT
FROM FROM
reference_table_test, colocated_table_test reference_table_test, colocated_table_test
WHERE WHERE
colocated_table_test.value_1 = reference_table_test.value_1; colocated_table_test.value_1 = reference_table_test.value_1
ORDER BY 1;
LOG: join order: [ "colocated_table_test" ][ reference join "reference_table_test" ] LOG: join order: [ "colocated_table_test" ][ reference join "reference_table_test" ]
value_1 value_1
--------------------------------------------------------------------- ---------------------------------------------------------------------
@ -1033,7 +1034,8 @@ SELECT
FROM FROM
reference_table_test, colocated_table_test reference_table_test, colocated_table_test
WHERE WHERE
colocated_table_test.value_2 = reference_table_test.value_2; colocated_table_test.value_2 = reference_table_test.value_2
ORDER BY 1;
LOG: join order: [ "colocated_table_test" ][ reference join "reference_table_test" ] LOG: join order: [ "colocated_table_test" ][ reference join "reference_table_test" ]
value_2 value_2
--------------------------------------------------------------------- ---------------------------------------------------------------------
@ -1046,7 +1048,8 @@ SELECT
FROM FROM
colocated_table_test, reference_table_test colocated_table_test, reference_table_test
WHERE WHERE
reference_table_test.value_1 = colocated_table_test.value_1; reference_table_test.value_1 = colocated_table_test.value_1
ORDER BY 1;
LOG: join order: [ "colocated_table_test" ][ reference join "reference_table_test" ] LOG: join order: [ "colocated_table_test" ][ reference join "reference_table_test" ]
value_2 value_2
--------------------------------------------------------------------- ---------------------------------------------------------------------
@ -1150,6 +1153,7 @@ FROM
colocated_table_test_2, reference_table_test colocated_table_test_2, reference_table_test
WHERE WHERE
colocated_table_test_2.value_4 = reference_table_test.value_4 colocated_table_test_2.value_4 = reference_table_test.value_4
ORDER BY 1
RETURNING value_1, value_2; RETURNING value_1, value_2;
value_1 | value_2 value_1 | value_2
--------------------------------------------------------------------- ---------------------------------------------------------------------

10
src/test/regress/sql/multi_reference_table.sql
View File

@ -643,21 +643,24 @@ SELECT
FROM FROM
reference_table_test, colocated_table_test reference_table_test, colocated_table_test
WHERE WHERE
colocated_table_test.value_1 = reference_table_test.value_1; colocated_table_test.value_1 = reference_table_test.value_1
ORDER BY 1;
SELECT SELECT
colocated_table_test.value_2 colocated_table_test.value_2
FROM FROM
reference_table_test, colocated_table_test reference_table_test, colocated_table_test
WHERE WHERE
colocated_table_test.value_2 = reference_table_test.value_2; colocated_table_test.value_2 = reference_table_test.value_2
ORDER BY 1;
SELECT SELECT
colocated_table_test.value_2 colocated_table_test.value_2
FROM FROM
colocated_table_test, reference_table_test colocated_table_test, reference_table_test
WHERE WHERE
reference_table_test.value_1 = colocated_table_test.value_1; reference_table_test.value_1 = colocated_table_test.value_1
ORDER BY 1;
SET citus.enable_repartition_joins = on; SET citus.enable_repartition_joins = on;
SELECT SELECT
@ -730,6 +733,7 @@ FROM
colocated_table_test_2, reference_table_test colocated_table_test_2, reference_table_test
WHERE WHERE
colocated_table_test_2.value_4 = reference_table_test.value_4 colocated_table_test_2.value_4 = reference_table_test.value_4
ORDER BY 1
RETURNING value_1, value_2; RETURNING value_1, value_2;
-- similar query with the above, this time partition key but without equality -- similar query with the above, this time partition key but without equality