From 1125fc9da048c1301daa903f9063bee0475b1b80 Mon Sep 17 00:00:00 2001 From: Jason Petersen Date: Tue, 16 Apr 2019 14:36:05 -0600 Subject: [PATCH] Fix self-strncmp in ConstrIsFKToReferenceTable Make the function do what I assume was intended. --- src/backend/distributed/commands/foreign_constraint.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/distributed/commands/foreign_constraint.c b/src/backend/distributed/commands/foreign_constraint.c index dc022e51a..f9bdc99c4 100644 --- a/src/backend/distributed/commands/foreign_constraint.c +++ b/src/backend/distributed/commands/foreign_constraint.c @@ -42,7 +42,7 @@ static bool HeapTupleOfForeignConstraintIncludesColumn(HeapTuple heapTuple, Oid * of them is a foreign key referencing to a reference table. */ bool -ConstraintIsAForeignKeyToReferenceTable(char *constraintName, Oid relationId) +ConstraintIsAForeignKeyToReferenceTable(char *constraintNameInput, Oid relationId) { Relation pgConstraint = NULL; SysScanDesc scanDescriptor = NULL; @@ -66,7 +66,7 @@ ConstraintIsAForeignKeyToReferenceTable(char *constraintName, Oid relationId) Form_pg_constraint constraintForm = (Form_pg_constraint) GETSTRUCT(heapTuple); char *constraintName = (constraintForm->conname).data; - if (strncmp(constraintName, constraintName, NAMEDATALEN) != 0 || + if (strncmp(constraintNameInput, constraintName, NAMEDATALEN) != 0 || constraintForm->conrelid != relationId) { heapTuple = systable_getnext(scanDescriptor);