external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3976 from citusdata/fix/foreign-key-to-local-table-hint 

Improve error message when creating a foreign key to a local table
pull/3906/head
Marco Slot 2020-07-15 14:30:19 +02:00 committed by GitHub
parent e09860e9e3 9cb8dc9d12
commit 1baf6c3a45
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/backend/distributed/commands/foreign_constraint.c
View File

@ -150,10 +150,18 @@ ErrorIfUnsupportedForeignConstraintExists(Relation relation, char referencingDis
if (!referencedIsCitus && !selfReferencingTable) if (!referencedIsCitus && !selfReferencingTable)
{ {
char *referencedTableName = get_rel_name(referencedTableId);
ereport(ERROR, (errcode(ERRCODE_INVALID_TABLE_DEFINITION), ereport(ERROR, (errcode(ERRCODE_INVALID_TABLE_DEFINITION),
errmsg("cannot create foreign key constraint"), errmsg("referenced table \"%s\" must be a distributed table"
errdetail("Referenced table must be a distributed table" " or a reference table",
" or a reference table."))); referencedTableName),
errdetail("To enforce foreign keys, the referencing and "
"referenced rows need to be stored on the same "
"node."),
errhint("You could use SELECT create_reference_table('%s') "
"to replicate the referenced table to all nodes",
referencedTableName)));
} }
/* set referenced table related variables here if table is referencing itself */ /* set referenced table related variables here if table is referencing itself */

10
src/test/regress/expected/multi_foreign_key.out
View File

@ -859,8 +859,9 @@ DROP TABLE reference_table CASCADE;
NOTICE: drop cascades to constraint reference_table_second_referencing_column_fkey on table reference_table_second NOTICE: drop cascades to constraint reference_table_second_referencing_column_fkey on table reference_table_second
CREATE TABLE reference_table(id int, referencing_column int REFERENCES referenced_local_table(id)); CREATE TABLE reference_table(id int, referencing_column int REFERENCES referenced_local_table(id));
SELECT create_reference_table('reference_table'); SELECT create_reference_table('reference_table');
ERROR: cannot create foreign key constraint ERROR: referenced table "referenced_local_table" must be a distributed table or a reference table
DETAIL: Referenced table must be a distributed table or a reference table. DETAIL: To enforce foreign keys, the referencing and referenced rows need to be stored on the same node.
HINT: You could use SELECT create_reference_table('referenced_local_table') to replicate the referenced table to all nodes
-- test foreign key creation on CREATE TABLE on self referencing reference table -- test foreign key creation on CREATE TABLE on self referencing reference table
CREATE TABLE self_referencing_reference_table( CREATE TABLE self_referencing_reference_table(
id int, id int,
@ -919,8 +920,9 @@ SELECT create_reference_table('reference_table');
(1 row) (1 row)
ALTER TABLE reference_table ADD CONSTRAINT fk FOREIGN KEY(referencing_column) REFERENCES referenced_local_table(id); ALTER TABLE reference_table ADD CONSTRAINT fk FOREIGN KEY(referencing_column) REFERENCES referenced_local_table(id);
ERROR: cannot create foreign key constraint ERROR: referenced table "referenced_local_table" must be a distributed table or a reference table
DETAIL: Referenced table must be a distributed table or a reference table. DETAIL: To enforce foreign keys, the referencing and referenced rows need to be stored on the same node.
HINT: You could use SELECT create_reference_table('referenced_local_table') to replicate the referenced table to all nodes
-- test foreign key creation on ALTER TABLE on self referencing reference table -- test foreign key creation on ALTER TABLE on self referencing reference table
DROP TABLE self_referencing_reference_table; DROP TABLE self_referencing_reference_table;
CREATE TABLE self_referencing_reference_table( CREATE TABLE self_referencing_reference_table(