Merge pull request #5749 from citusdata/improve_check_multi

Drop function in the tests on a never version
pull/5735/head
Önder Kalacı 2022-03-02 08:51:26 +01:00 committed by GitHub
commit 1e876abc56
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 57 additions and 58 deletions

View File

@ -1115,8 +1115,7 @@ HINT: Use DROP FUNCTION relation_is_a_known_shard(regclass) first.
SET citus.enable_version_checks TO 'false'; SET citus.enable_version_checks TO 'false';
SET columnar.enable_version_checks TO 'false'; SET columnar.enable_version_checks TO 'false';
-- This will fail because of previous function declaration -- This will fail because of previous function declaration
ALTER EXTENSION citus UPDATE TO '8.1-1'; ALTER EXTENSION citus UPDATE TO '9.1-1';
NOTICE: version "8.1-1" of extension "citus" is already installed
-- We can DROP problematic function and continue ALTER EXTENSION even when version checks are on -- We can DROP problematic function and continue ALTER EXTENSION even when version checks are on
SET citus.enable_version_checks TO 'true'; SET citus.enable_version_checks TO 'true';
SET columnar.enable_version_checks TO 'true'; SET columnar.enable_version_checks TO 'true';
@ -1125,8 +1124,8 @@ ERROR: cannot drop function relation_is_a_known_shard(regclass) because extensi
HINT: You can drop extension citus instead. HINT: You can drop extension citus instead.
SET citus.enable_version_checks TO 'false'; SET citus.enable_version_checks TO 'false';
SET columnar.enable_version_checks TO 'false'; SET columnar.enable_version_checks TO 'false';
ALTER EXTENSION citus UPDATE TO '8.1-1'; ALTER EXTENSION citus UPDATE TO '9.1-1';
NOTICE: version "8.1-1" of extension "citus" is already installed NOTICE: version "9.1-1" of extension "citus" is already installed
-- Test updating to the latest version without specifying the version number -- Test updating to the latest version without specifying the version number
ALTER EXTENSION citus UPDATE; ALTER EXTENSION citus UPDATE;
-- re-create in newest version -- re-create in newest version

View File

@ -526,7 +526,7 @@ $function$;
SET citus.enable_version_checks TO 'false'; SET citus.enable_version_checks TO 'false';
SET columnar.enable_version_checks TO 'false'; SET columnar.enable_version_checks TO 'false';
-- This will fail because of previous function declaration -- This will fail because of previous function declaration
ALTER EXTENSION citus UPDATE TO '8.1-1'; ALTER EXTENSION citus UPDATE TO '9.1-1';
-- We can DROP problematic function and continue ALTER EXTENSION even when version checks are on -- We can DROP problematic function and continue ALTER EXTENSION even when version checks are on
SET citus.enable_version_checks TO 'true'; SET citus.enable_version_checks TO 'true';
@ -535,7 +535,7 @@ DROP FUNCTION pg_catalog.relation_is_a_known_shard(regclass);
SET citus.enable_version_checks TO 'false'; SET citus.enable_version_checks TO 'false';
SET columnar.enable_version_checks TO 'false'; SET columnar.enable_version_checks TO 'false';
ALTER EXTENSION citus UPDATE TO '8.1-1'; ALTER EXTENSION citus UPDATE TO '9.1-1';
-- Test updating to the latest version without specifying the version number -- Test updating to the latest version without specifying the version number
ALTER EXTENSION citus UPDATE; ALTER EXTENSION citus UPDATE;