external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix creating stats bug when CREATE TABLE LIKE (#6006)

velioglu/dont_drop_mat_view_alter_table
Ahmet Gedemenli 2022-06-16 12:43:47 +03:00 committed by GitHub
parent 184c7c0bce
commit 1ee3e8b7f4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/distributed/deparser/qualify_statistics_stmt.c
View File

@ -42,6 +42,12 @@ QualifyCreateStatisticsStmt(Node *node)
relation->schemaname = get_namespace_name(schemaOid);
}
if (list_length(stmt->defnames) < 1)
{
/* no name to qualify */
return;
}
RangeVar *stat = makeRangeVarFromNameList(stmt->defnames);
if (stat->schemaname == NULL)

12
src/test/regress/expected/pg14.out
View File

@ -1364,6 +1364,18 @@ SELECT count(*) FROM pg14.foreign_table;
TRUNCATE foreign_table;
ERROR: truncating foreign tables that are added to metadata can only be executed on the coordinator
\c - - - :master_port
SET search_path TO pg14;
-- an example with CREATE TABLE LIKE, with statistics with expressions
CREATE TABLE ctlt1 (a text CHECK (length(a) > 2) PRIMARY KEY, b text);
CREATE STATISTICS ctlt1_expr_stat ON (a || b) FROM ctlt1;
CREATE TABLE ctlt_all (LIKE ctlt1 INCLUDING ALL);
SELECT create_distributed_table('ctlt1', 'a');
create_distributed_table
---------------------------------------------------------------------
(1 row)
CREATE TABLE ctlt_all_2 (LIKE ctlt1 INCLUDING ALL);
-- cleanup
set client_min_messages to error;
drop extension postgres_fdw cascade;

7
src/test/regress/sql/pg14.sql
View File

@ -706,6 +706,13 @@ SELECT count(*) FROM pg14.foreign_table;
-- should error out
TRUNCATE foreign_table;
\c - - - :master_port
SET search_path TO pg14;
-- an example with CREATE TABLE LIKE, with statistics with expressions
CREATE TABLE ctlt1 (a text CHECK (length(a) > 2) PRIMARY KEY, b text);
CREATE STATISTICS ctlt1_expr_stat ON (a || b) FROM ctlt1;
CREATE TABLE ctlt_all (LIKE ctlt1 INCLUDING ALL);
SELECT create_distributed_table('ctlt1', 'a');
CREATE TABLE ctlt_all_2 (LIKE ctlt1 INCLUDING ALL);
-- cleanup
set client_min_messages to error;
drop extension postgres_fdw cascade;