external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use cached comparator in ShardIntervalsOverlap(). 

By far the most expensive part of ShardIntervalsOverlap() is computing
the function to use to determine overlap. Luckily we already have that
computed and cached.

The plan time for the query in issue #607 goes from 8764 ms to 2889 ms
with this change.
pull/608/head
Andres Freund 2016-06-16 14:49:00 -07:00
parent e697bf7ca7
commit 211a9721a9
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/distributed/planner/multi_physical_planner.c
View File

@ -3601,17 +3601,16 @@ FragmentInterval(RangeTableFragment *fragment)
bool bool
ShardIntervalsOverlap(ShardInterval *firstInterval, ShardInterval *secondInterval) ShardIntervalsOverlap(ShardInterval *firstInterval, ShardInterval *secondInterval)
{ {
Oid typeId = InvalidOid;
FmgrInfo *comparisonFunction = NULL;
bool nonOverlap = false; bool nonOverlap = false;
DistTableCacheEntry *intervalRelation =
DistributedTableCacheEntry(firstInterval->relationId);
FmgrInfo *comparisonFunction = intervalRelation->shardIntervalCompareFunction;
Datum firstMin = 0; Datum firstMin = 0;
Datum firstMax = 0; Datum firstMax = 0;
Datum secondMin = 0; Datum secondMin = 0;
Datum secondMax = 0; Datum secondMax = 0;
typeId = firstInterval->valueTypeId;
comparisonFunction = GetFunctionInfo(typeId, BTREE_AM_OID, BTORDER_PROC);
firstMin = firstInterval->minValue; firstMin = firstInterval->minValue;
firstMax = firstInterval->maxValue; firstMax = firstInterval->maxValue;