From 24188959ed6433c61f61e527d2d25e5e507ff35d Mon Sep 17 00:00:00 2001 From: Onur Tirtir Date: Thu, 25 Jan 2024 11:22:39 +0300 Subject: [PATCH] Improve the script that sorts GUCs in alphabetical order (#7452) Soon we will have occurrences of "citus.X" in shared_library_init.c that are not part of GUC defs, so we need to use a more precise regular expression. --- ci/check_gucs_are_alphabetically_sorted.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ci/check_gucs_are_alphabetically_sorted.sh b/ci/check_gucs_are_alphabetically_sorted.sh index 763b5305f..3d368e708 100755 --- a/ci/check_gucs_are_alphabetically_sorted.sh +++ b/ci/check_gucs_are_alphabetically_sorted.sh @@ -4,7 +4,7 @@ set -euo pipefail # shellcheck disable=SC1091 source ci/ci_helpers.sh -# extract citus gucs in the form of "citus.X" -grep -o -E "(\.*\"citus\.\w+\")," src/backend/distributed/shared_library_init.c > gucs.out +# extract citus gucs in the form of "citus.X" +grep -P "^[\t][\t]\"citus\.[a-zA-Z_0-9]+\"" src/backend/distributed/shared_library_init.c > gucs.out sort -c gucs.out rm gucs.out