Fix memory leak in FinishRemoteTransactionPrepare

release-7.5
Murat Tuncer 2018-09-28 11:13:21 +03:00 committed by velioglu
parent c95b13863b
commit 25673600d3
1 changed files with 16 additions and 2 deletions

View File

@ -528,8 +528,22 @@ FinishRemoteTransactionPrepare(struct MultiConnection *connection)
transaction->transactionState = REMOTE_TRANS_PREPARED;
}
result = GetRemoteCommandResult(connection, raiseErrors);
Assert(!result);
PQclear(result);
/*
* Try to consume results of PREPARE TRANSACTION command. If we don't
* succeed, rollback the transaction. Note that we've not committed on
* any node yet, and we're not sure about the state of the worker node.
* So rollbacking seems to be the safest action if the worker is
* in a state where it can actually rollback.
*/
if (!ClearResults(connection, raiseErrors))
{
ereport(ERROR, (errmsg("failed to prepare transaction '%s' on host %s:%d",
transaction->preparedName, connection->hostname,
connection->port),
errhint("Try re-running the command.")));
}
}