external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

improve the comments and make arr cells const too

pull/7544/head
Onur Tirtir 2024-03-19 11:26:24 +03:00
parent 5944672940
commit 2a5b343ca1
1 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/backend/distributed/commands/non_main_db_distribute_object_ops.c
View File

@ -11,8 +11,11 @@
* commands from non-main databases. * commands from non-main databases.
* *
* To add support for a new command type, one needs to define a new * To add support for a new command type, one needs to define a new
* NonMainDbDistributeObjectOps object and add it to * NonMainDbDistributeObjectOps object within OperationArray. Then, if
* GetNonMainDbDistributeObjectOps. * the command type is supported in under special circumstances, this
* can be be implemented in GetNonMainDbDistributeObjectOps. Otherwise,
* that function will yield the operations defined for the command via
* the "default" case of the switch statement.
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -121,15 +124,9 @@ static List * DropRoleStmtGetUnmarkDistributedParams(Node *parsetree);
/* /*
* NonMainDbDistributeObjectOps for different command types. * OperationArray that holds NonMainDbDistributeObjectOps for different command types.
*
* Naming of these structs are stolen from distribute_object_ops.c. We use
* "Any" if the command doesn't have any other variations or if the struct
* implements it for all its variations. For example, while we name the struct
* for CreateRoleStmt as Any_CreateRole, we name the struct that implements
* SecLabelStmt for role objects as Role_SecLabel.
*/ */
static const NonMainDbDistributeObjectOps *operationArray[] = { static const NonMainDbDistributeObjectOps * const OperationArray[] = {
[T_CreateRoleStmt] = &(NonMainDbDistributeObjectOps) { [T_CreateRoleStmt] = &(NonMainDbDistributeObjectOps) {
.getMarkDistributedParams = CreateRoleStmtGetMarkDistributedParams, .getMarkDistributedParams = CreateRoleStmtGetMarkDistributedParams,
.getUnmarkDistributedParams = NULL, .getUnmarkDistributedParams = NULL,
@ -172,6 +169,7 @@ static const NonMainDbDistributeObjectOps *operationArray[] = {
}, },
}; };
/* other static function declarations */ /* other static function declarations */
const NonMainDbDistributeObjectOps * GetNonMainDbDistributeObjectOps(Node *parsetree); const NonMainDbDistributeObjectOps * GetNonMainDbDistributeObjectOps(Node *parsetree);
static void MarkObjectDistributedGloballyOnMainDbs( static void MarkObjectDistributedGloballyOnMainDbs(
@ -275,12 +273,12 @@ const NonMainDbDistributeObjectOps *
GetNonMainDbDistributeObjectOps(Node *parsetree) GetNonMainDbDistributeObjectOps(Node *parsetree)
{ {
NodeTag tag = nodeTag(parsetree); NodeTag tag = nodeTag(parsetree);
if (tag >= lengthof(operationArray)) if (tag >= lengthof(OperationArray))
{ {
return NULL; return NULL;
} }
const NonMainDbDistributeObjectOps *ops = operationArray[tag]; const NonMainDbDistributeObjectOps *ops = OperationArray[tag];
switch (nodeTag(parsetree)) switch (nodeTag(parsetree))
{ {