external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve safety check in FindReferencedTableColumn to assert valid groupIndex

m3hm3t/pg18_pushdown_group_column
Mehmet Yilmaz 2025-07-04 08:16:49 +00:00
parent cd017ee69c
commit 2b30606970
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/distributed/planner/multi_logical_optimizer.c
View File

@ -4568,11 +4568,9 @@ FindReferencedTableColumn(Expr *columnExpression, List *parentQueryList, Query *
List *groupexprs = rangeTableEntry->groupexprs;
AttrNumber groupIndex = candidateColumn->varattno - 1;
/* Safety check */
if (groupIndex < 0 || groupIndex >= list_length(groupexprs))
{
return; /* malformed Var */
}
/* this must always hold unless upstream Postgres mis-constructed the RTE_GROUP */
Assert(groupIndex >= 0 && groupIndex < list_length(groupexprs));
Expr *groupExpr = (Expr *) list_nth(groupexprs, groupIndex);
/* Recurse on the underlying expression (stay in the same query) */