From 2edaf0971c22fac81675faaaf4b34df9fc35a555 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Halil=20Ozan=20Akg=C3=BCl?= Date: Fri, 11 Mar 2022 11:27:46 +0300 Subject: [PATCH] Turn metadata sync on in isolation reference copy vs all (#5790) * Turn metadata sync on in isolation_reference_copy_vs_all test * Update the output of isolation_reference_copy_vs_all test --- .../isolation_reference_copy_vs_all.out | 192 +++++++++++++++++- src/test/regress/isolation_schedule | 2 +- .../spec/isolation_reference_copy_vs_all.spec | 3 + 3 files changed, 190 insertions(+), 7 deletions(-) diff --git a/src/test/regress/expected/isolation_reference_copy_vs_all.out b/src/test/regress/expected/isolation_reference_copy_vs_all.out index a90eec3ef..c73cc3031 100644 --- a/src/test/regress/expected/isolation_reference_copy_vs_all.out +++ b/src/test/regress/expected/isolation_reference_copy_vs_all.out @@ -17,6 +17,11 @@ count 15 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-copy s2-router-select s1-commit s1-select-count create_reference_table @@ -40,6 +45,11 @@ count 10 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-copy s2-real-time-select s1-commit s1-select-count create_reference_table @@ -67,6 +77,11 @@ count 10 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-copy s2-adaptive-select s1-commit s1-select-count create_reference_table @@ -96,6 +111,11 @@ count 10 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-copy s2-insert s1-commit s1-select-count create_reference_table @@ -114,6 +134,11 @@ count 11 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-copy s2-insert-select s1-commit s1-select-count create_reference_table @@ -133,6 +158,11 @@ count 20 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-copy s2-update s1-commit s1-select-count create_reference_table @@ -152,6 +182,11 @@ count 10 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-copy s2-delete s1-commit s1-select-count create_reference_table @@ -171,6 +206,11 @@ count 9 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-copy s2-truncate s1-commit s1-select-count create_reference_table @@ -190,6 +230,11 @@ count 0 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-copy s2-drop s1-commit s1-select-count create_reference_table @@ -205,6 +250,11 @@ step s1-commit: COMMIT; step s2-drop: <... completed> step s1-select-count: SELECT COUNT(*) FROM reference_copy; ERROR: relation "reference_copy" does not exist +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-copy s2-ddl-create-index s1-commit s1-select-count s1-show-indexes create_reference_table @@ -227,10 +277,15 @@ count step s1-show-indexes: SELECT run_command_on_workers('SELECT COUNT(*) FROM pg_indexes WHERE tablename LIKE ''reference_copy%'''); run_command_on_workers --------------------------------------------------------------------- -(localhost,57637,t,1) -(localhost,57638,t,1) +(localhost,57637,t,2) +(localhost,57638,t,2) (2 rows) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-ddl-create-index s1-begin s1-copy s2-ddl-drop-index s1-commit s1-select-count s1-show-indexes create_reference_table @@ -258,6 +313,11 @@ run_command_on_workers (localhost,57638,t,0) (2 rows) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-copy s2-ddl-create-index-concurrently s1-commit s1-select-count s1-show-indexes create_reference_table @@ -280,10 +340,15 @@ count step s1-show-indexes: SELECT run_command_on_workers('SELECT COUNT(*) FROM pg_indexes WHERE tablename LIKE ''reference_copy%'''); run_command_on_workers --------------------------------------------------------------------- -(localhost,57637,t,1) -(localhost,57638,t,1) +(localhost,57637,t,2) +(localhost,57638,t,2) (2 rows) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-copy s2-ddl-add-column s1-commit s1-select-count s1-show-columns create_reference_table @@ -310,6 +375,11 @@ run_command_on_workers (localhost,57638,t,new_column) (2 rows) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-ddl-add-column s1-begin s1-copy-additional-column s2-ddl-drop-column s1-commit s1-select-count s1-show-columns create_reference_table @@ -337,6 +407,11 @@ run_command_on_workers (localhost,57638,t,"") (2 rows) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-copy s2-ddl-rename-column s1-commit s1-select-count s1-show-columns create_reference_table @@ -363,6 +438,11 @@ run_command_on_workers (localhost,57638,t,new_column) (2 rows) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-copy s2-table-size s1-commit s1-select-count create_reference_table @@ -386,6 +466,11 @@ count 10 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-copy s2-master-modify-multiple-shards s1-commit s1-select-count create_reference_table @@ -405,6 +490,11 @@ count 0 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-drop s1-create-non-distributed-table s1-initialize s1-begin s1-copy s2-distribute-table s1-commit s1-select-count create_reference_table @@ -431,6 +521,11 @@ count 15 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-router-select s2-copy s1-commit s1-select-count create_reference_table @@ -454,6 +549,11 @@ count 10 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-real-time-select s2-copy s1-commit s1-select-count create_reference_table @@ -481,6 +581,11 @@ count 10 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-adaptive-select s2-copy s1-commit s1-select-count create_reference_table @@ -510,6 +615,11 @@ count 10 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-insert s2-copy s1-commit s1-select-count create_reference_table @@ -528,6 +638,11 @@ count 11 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-insert-select s2-copy s1-commit s1-select-count create_reference_table @@ -547,6 +662,11 @@ count 15 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-update s2-copy s1-commit s1-select-count create_reference_table @@ -566,6 +686,11 @@ count 10 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-delete s2-copy s1-commit s1-select-count create_reference_table @@ -585,6 +710,11 @@ count 9 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-truncate s2-copy s1-commit s1-select-count create_reference_table @@ -604,6 +734,11 @@ count 5 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-drop s2-copy s1-commit s1-select-count create_reference_table @@ -620,6 +755,11 @@ step s2-copy: <... completed> ERROR: relation "reference_copy" does not exist step s1-select-count: SELECT COUNT(*) FROM reference_copy; ERROR: relation "reference_copy" does not exist +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-ddl-create-index s2-copy s1-commit s1-select-count s1-show-indexes create_reference_table @@ -642,10 +782,15 @@ count step s1-show-indexes: SELECT run_command_on_workers('SELECT COUNT(*) FROM pg_indexes WHERE tablename LIKE ''reference_copy%'''); run_command_on_workers --------------------------------------------------------------------- -(localhost,57637,t,1) -(localhost,57638,t,1) +(localhost,57637,t,2) +(localhost,57638,t,2) (2 rows) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-ddl-create-index s1-begin s1-ddl-drop-index s2-copy s1-commit s1-select-count s1-show-indexes create_reference_table @@ -673,6 +818,11 @@ run_command_on_workers (localhost,57638,t,0) (2 rows) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-ddl-add-column s2-copy s1-commit s1-select-count s1-show-columns create_reference_table @@ -700,6 +850,11 @@ run_command_on_workers (localhost,57638,t,new_column) (2 rows) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-ddl-add-column s1-begin s1-ddl-drop-column s2-copy s1-commit s1-select-count s1-show-columns create_reference_table @@ -727,6 +882,11 @@ run_command_on_workers (localhost,57638,t,"") (2 rows) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-ddl-rename-column s2-copy s1-commit s1-select-count s1-show-columns create_reference_table @@ -753,6 +913,11 @@ run_command_on_workers (localhost,57638,t,new_column) (2 rows) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-table-size s2-copy s1-commit s1-select-count create_reference_table @@ -776,6 +941,11 @@ count 10 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-initialize s1-begin s1-master-modify-multiple-shards s2-copy s1-commit s1-select-count create_reference_table @@ -795,6 +965,11 @@ count 5 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + starting permutation: s1-drop s1-create-non-distributed-table s1-initialize s1-begin s1-distribute-table s2-copy s1-commit s1-select-count create_reference_table @@ -821,3 +996,8 @@ count 15 (1 row) +restore_isolation_tester_func +--------------------------------------------------------------------- + +(1 row) + diff --git a/src/test/regress/isolation_schedule b/src/test/regress/isolation_schedule index 8f849d5dd..8df57a237 100644 --- a/src/test/regress/isolation_schedule +++ b/src/test/regress/isolation_schedule @@ -46,6 +46,7 @@ test: isolation_multi_shard_modify_vs_all test: isolation_modify_with_subquery_vs_dml test: isolation_hash_copy_vs_all test: isolation_range_copy_vs_all +test: isolation_reference_copy_vs_all test: isolation_partitioned_copy_vs_all test: isolation_select_vs_all test: isolation_insert_vs_all @@ -98,5 +99,4 @@ test: isolation_multiuser_locking # MXless tests test: isolation_check_mx test: isolation_turn_mx_off -test: isolation_reference_copy_vs_all test: isolation_ref2ref_foreign_keys diff --git a/src/test/regress/spec/isolation_reference_copy_vs_all.spec b/src/test/regress/spec/isolation_reference_copy_vs_all.spec index 1ee681b81..b327230d9 100644 --- a/src/test/regress/spec/isolation_reference_copy_vs_all.spec +++ b/src/test/regress/spec/isolation_reference_copy_vs_all.spec @@ -5,6 +5,8 @@ // create append distributed table to test behavior of COPY in concurrent operations setup { + SELECT citus_internal.replace_isolation_tester_func(); + SELECT citus_internal.refresh_isolation_tester_prepared_statement(); SET citus.shard_replication_factor TO 1; CREATE TABLE reference_copy(id integer, data text, int_data int); SELECT create_reference_table('reference_copy'); @@ -14,6 +16,7 @@ setup teardown { DROP TABLE IF EXISTS reference_copy CASCADE; + SELECT citus_internal.restore_isolation_tester_func(); } // session 1