external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix error thrown for foreign keys from citus local to dist tables (#4490)

pull/4499/head
Onur Tirtir 2021-01-13 10:15:12 +03:00 committed by GitHub
parent dd55ab394e
commit 2ef5879bcc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/distributed/commands/foreign_constraint.c
View File

@ -216,10 +216,11 @@ ErrorIfUnsupportedForeignConstraintExists(Relation relation, char referencingDis
ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("cannot create foreign key constraint " errmsg("cannot create foreign key constraint "
"since foreign keys from reference tables " "since foreign keys from reference tables "
"to distributed tables are not supported"), "and citus local tables to distributed tables "
errdetail("A reference table can only have foreign " "are not supported"),
"keys to other reference tables or citus " errdetail("Reference tables and citus local tables "
"local tables"))); "can only have foreign keys to reference "
"tables and citus local tables")));
} }
/* /*

2
src/test/regress/expected/citus_local_tables.out
View File

@ -417,7 +417,7 @@ SET search_path TO citus_local_tables_test_schema;
-- more tests at ref_citus_local_fkeys.sql -- more tests at ref_citus_local_fkeys.sql
-- between citus local tables and distributed tables -- between citus local tables and distributed tables
ALTER TABLE citus_local_table_1 ADD CONSTRAINT fkey_c_to_dist FOREIGN KEY(a) references distributed_table(a); ALTER TABLE citus_local_table_1 ADD CONSTRAINT fkey_c_to_dist FOREIGN KEY(a) references distributed_table(a);
ERROR: cannot create foreign key constraint since foreign keys from reference tables to distributed tables are not supported ERROR: cannot create foreign key constraint since foreign keys from reference tables and citus local tables to distributed tables are not supported
ALTER TABLE distributed_table ADD CONSTRAINT fkey_dist_to_c FOREIGN KEY(a) references citus_local_table_1(a); ALTER TABLE distributed_table ADD CONSTRAINT fkey_dist_to_c FOREIGN KEY(a) references citus_local_table_1(a);
ERROR: cannot create foreign key constraint since relations are not colocated or not referencing a reference table ERROR: cannot create foreign key constraint since relations are not colocated or not referencing a reference table
-- between citus local tables and local tables -- between citus local tables and local tables

8
src/test/regress/expected/multi_foreign_key.out
View File

@ -835,8 +835,8 @@ SELECT create_distributed_table('referenced_by_reference_table', 'id');
CREATE TABLE reference_table(id int, referencing_column int REFERENCES referenced_by_reference_table(id)); CREATE TABLE reference_table(id int, referencing_column int REFERENCES referenced_by_reference_table(id));
SELECT create_reference_table('reference_table'); SELECT create_reference_table('reference_table');
ERROR: cannot create foreign key constraint since foreign keys from reference tables to distributed tables are not supported ERROR: cannot create foreign key constraint since foreign keys from reference tables and citus local tables to distributed tables are not supported
DETAIL: A reference table can only have foreign keys to other reference tables or citus local tables DETAIL: Reference tables and citus local tables can only have foreign keys to reference tables and citus local tables
-- test foreign key creation on CREATE TABLE from + to reference table -- test foreign key creation on CREATE TABLE from + to reference table
DROP TABLE reference_table; DROP TABLE reference_table;
CREATE TABLE reference_table(id int PRIMARY KEY, referencing_column int); CREATE TABLE reference_table(id int PRIMARY KEY, referencing_column int);
@ -886,8 +886,8 @@ SELECT create_reference_table('reference_table');
(1 row) (1 row)
ALTER TABLE reference_table ADD CONSTRAINT fk FOREIGN KEY(referencing_column) REFERENCES referenced_by_reference_table(id); ALTER TABLE reference_table ADD CONSTRAINT fk FOREIGN KEY(referencing_column) REFERENCES referenced_by_reference_table(id);
ERROR: cannot create foreign key constraint since foreign keys from reference tables to distributed tables are not supported ERROR: cannot create foreign key constraint since foreign keys from reference tables and citus local tables to distributed tables are not supported
DETAIL: A reference table can only have foreign keys to other reference tables or citus local tables DETAIL: Reference tables and citus local tables can only have foreign keys to reference tables and citus local tables
-- test foreign key creation on ALTER TABLE to reference table -- test foreign key creation on ALTER TABLE to reference table
CREATE TABLE references_to_reference_table(id int, referencing_column int); CREATE TABLE references_to_reference_table(id int, referencing_column int);
SELECT create_distributed_table('references_to_reference_table', 'referencing_column'); SELECT create_distributed_table('references_to_reference_table', 'referencing_column');