From 32156dbf5c81afa19d88dde17138cd8623483804 Mon Sep 17 00:00:00 2001 From: SaitTalhaNisanci Date: Fri, 3 Apr 2020 17:01:59 +0300 Subject: [PATCH] fix flaky log statement in null_parameters (#3705) It seems that sometimes the pruning is deferred and sometimes not with this statement. What we care in this test is to see that it doesn't crash. I think we don't care about the log statement for this line. So it makes sense to not log this statement, and care about the result. --- src/test/regress/expected/null_parameters.out | 4 ++++ src/test/regress/sql/null_parameters.sql | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/src/test/regress/expected/null_parameters.out b/src/test/regress/expected/null_parameters.out index 8f6c17922..578e21fb9 100644 --- a/src/test/regress/expected/null_parameters.out +++ b/src/test/regress/expected/null_parameters.out @@ -1575,6 +1575,10 @@ DEBUG: Plan is router executable 0 (1 row) +-- it seems that sometimes the pruning is deferred and sometimes not. +-- what we care about is that this doesn't crash and the log for this +-- one shouldn't matter. This is to prevent this test being from flaky. +SET client_min_messages to ERROR; EXECUTE null_select_on_json_param(NULL); count --------------------------------------------------------------------- diff --git a/src/test/regress/sql/null_parameters.sql b/src/test/regress/sql/null_parameters.sql index bb2d8fc9f..0fab8e790 100644 --- a/src/test/regress/sql/null_parameters.sql +++ b/src/test/regress/sql/null_parameters.sql @@ -309,6 +309,10 @@ EXECUTE null_select_on_json_param(NULL); EXECUTE null_select_on_json_param(NULL); EXECUTE null_select_on_json_param(NULL); EXECUTE null_select_on_json_param(NULL); +-- it seems that sometimes the pruning is deferred and sometimes not. +-- what we care about is that this doesn't crash and the log for this +-- one shouldn't matter. This is to prevent this test being from flaky. +SET client_min_messages to ERROR; EXECUTE null_select_on_json_param(NULL); SET client_min_messages TO ERROR;