mirror of https://github.com/citusdata/citus.git
Push down window functions more liberally if the table doesn't have a dist key
parent
e5e5eb35c7
commit
37220a93f3
|
@ -422,38 +422,14 @@ IsOuterJoinExpr(Node *node)
|
||||||
bool
|
bool
|
||||||
SafeToPushdownWindowFunction(Query *query, StringInfo *errorDetail)
|
SafeToPushdownWindowFunction(Query *query, StringInfo *errorDetail)
|
||||||
{
|
{
|
||||||
ListCell *windowClauseCell = NULL;
|
|
||||||
List *windowClauseList = query->windowClause;
|
|
||||||
|
|
||||||
/*
|
|
||||||
* We need to check each window clause separately if there is a partition by clause
|
|
||||||
* and if it is partitioned on the distribution column.
|
|
||||||
*/
|
|
||||||
foreach(windowClauseCell, windowClauseList)
|
|
||||||
{
|
|
||||||
WindowClause *windowClause = lfirst(windowClauseCell);
|
|
||||||
|
|
||||||
if (!windowClause->partitionClause)
|
|
||||||
{
|
|
||||||
if (errorDetail)
|
|
||||||
{
|
|
||||||
*errorDetail = makeStringInfo();
|
|
||||||
appendStringInfoString(*errorDetail,
|
|
||||||
"Window functions without PARTITION BY on distribution "
|
|
||||||
"column is currently unsupported");
|
|
||||||
}
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!WindowPartitionOnDistributionColumn(query))
|
if (!WindowPartitionOnDistributionColumn(query))
|
||||||
{
|
{
|
||||||
if (errorDetail)
|
if (errorDetail)
|
||||||
{
|
{
|
||||||
*errorDetail = makeStringInfo();
|
*errorDetail = makeStringInfo();
|
||||||
appendStringInfoString(*errorDetail,
|
appendStringInfoString(*errorDetail,
|
||||||
"Window functions with PARTITION BY list missing distribution "
|
"Window functions should have a PARTITION BY clause list "
|
||||||
"column is currently unsupported");
|
"that contains distribution column");
|
||||||
}
|
}
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue