external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Dont call CreateCLT for the parent if it is a shard

support-partitioning-for-citus-local-tables
Ahmet Gedemenli 2021-08-23 18:52:42 +03:00
parent b3b75fecbc
commit 3a02999ffe
1 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/backend/distributed/commands/cascade_table_operation_for_connected_relations.c
View File

@ -26,6 +26,7 @@
#include "distributed/reference_table_utils.h" #include "distributed/reference_table_utils.h"
#include "distributed/relation_access_tracking.h" #include "distributed/relation_access_tracking.h"
#include "distributed/worker_protocol.h" #include "distributed/worker_protocol.h"
#include "distributed/worker_shard_visibility.h"
#include "miscadmin.h" #include "miscadmin.h"
#include "utils/builtins.h" #include "utils/builtins.h"
#include "utils/lsyscache.h" #include "utils/lsyscache.h"
@ -414,16 +415,29 @@ ExecuteCascadeOperationForRelationIdList(List *relationIdList,
*/ */
if (PartitionTable(relationId)) if (PartitionTable(relationId))
{ {
/*
* Here we also need to check if the parent is a shard or not.
* Because when creating Citus Local Tables from partitioned
* tables, the parent recursively calls the creation function
* for partitions. If one of those partitions have some foreign
* key, we will be checking this. In that case, since the
* attach/detach commands are not executed yet, the parent table
* will be a shard here (see the rename/create trick at
* CreateCitusLocalTable function). Because of that we should not
* call CreateCitusLocalTable for the parent again. Instead,
* we should call it for the partition table to successfully
* complete the conversion.
*/
Oid parentOid = PartitionParentOid(relationId); Oid parentOid = PartitionParentOid(relationId);
if (OidIsValid(parentOid) && !IsCitusTable(parentOid)) if (OidIsValid(parentOid) && !IsCitusTable(parentOid) &&
!RelationIsAKnownShard(parentOid))
{ {
CreateCitusLocalTable(parentOid, cascadeViaForeignKeys); CreateCitusLocalTable(parentOid, cascadeViaForeignKeys);
break;
} }
} }
else
{ CreateCitusLocalTable(relationId, cascadeViaForeignKeys);
CreateCitusLocalTable(relationId, cascadeViaForeignKeys);
}
} }
break; break;