external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor definition of routable queries

pull/896/head
Onder Kalaci 2016-10-20 12:16:47 +03:00
parent 9c0bb3fb00
commit 3a7e10a9b1
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/distributed/executor/multi_server_executor.c
View File

@ -113,6 +113,10 @@ JobExecutorType(MultiPlan *multiPlan)
* RouterExecutablePlan returns whether a multi-plan can be executed using the * RouterExecutablePlan returns whether a multi-plan can be executed using the
* router executor. Modify queries are always router executable, select queries * router executor. Modify queries are always router executable, select queries
* are router executable only if executorType is real time. * are router executable only if executorType is real time.
*
* With the multi task router executor, most of the assumptions in this function do not
* hold anymore. In the long term, we could consider adding a new field to workerJob
* and only execute router plannable queries with router executor.
*/ */
bool bool
RouterExecutablePlan(MultiPlan *multiPlan, MultiExecutorType executorType) RouterExecutablePlan(MultiPlan *multiPlan, MultiExecutorType executorType)
@ -127,7 +131,7 @@ RouterExecutablePlan(MultiPlan *multiPlan, MultiExecutorType executorType)
List *workerDependentTaskList = NIL; List *workerDependentTaskList = NIL;
bool masterQueryHasAggregates = false; bool masterQueryHasAggregates = false;
/* TODO: this is a hacky solution to allow 0 shard INSERT ... SELECT */ /* allow all INSERT ... SELECT queries (i.e., irrespective of taskCount) */
if (masterQuery == NULL) if (masterQuery == NULL)
{ {
return true; return true;