external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixes review comments

pull/7253/head
gindibay 2023-11-10 04:59:50 +03:00
parent 328e34969d
commit 3ab91c91a3
1 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/backend/distributed/commands/database.c
View File

@ -207,27 +207,24 @@ PreprocessAlterDatabaseStmt(Node *node, const char *queryString,
char *sql = DeparseTreeNode((Node *) stmt); char *sql = DeparseTreeNode((Node *) stmt);
List *commands = NULL; List *commands = list_make3(DISABLE_DDL_PROPAGATION,
sql,
ENABLE_DDL_PROPAGATION);
if (isSetTablespaceStatement(stmt)) if (isSetTablespaceStatement(stmt))
{ {
/*Set tablespace does not work inside a transaction.Therefore, we close the transaction before set tablespace /* Set tablespace does not work inside a transaction.Therefore, we need to use
* and open it again after set tablespace. * NontransactionalNodeDDLTask to run the command on the workers outside
* the transaction block.
*/ */
commands = list_make3(DISABLE_DDL_PROPAGATION,
sql,
ENABLE_DDL_PROPAGATION);
return NontransactionalNodeDDLTask(NON_COORDINATOR_NODES, commands); return NontransactionalNodeDDLTask(NON_COORDINATOR_NODES, commands);
} }
else else
{ {
commands = list_make3(DISABLE_DDL_PROPAGATION,
(void *) sql,
ENABLE_DDL_PROPAGATION);
return NodeDDLTaskList(NON_COORDINATOR_NODES, commands); return NodeDDLTaskList(NON_COORDINATOR_NODES, commands);
} }
return NIL;
} }
@ -265,7 +262,11 @@ PreprocessAlterDatabaseRefreshCollStmt(Node *node, const char *queryString,
#endif #endif
/*
* PreprocessAlterDatabaseRenameStmt is executed before the statement is applied to the local
* postgres instance. In this stage we prepare ALTER DATABASE RENAME statement to be run on
* all workers.
*/
List * List *
PreprocessAlterDatabaseRenameStmt(Node *node, const char *queryString, PreprocessAlterDatabaseRenameStmt(Node *node, const char *queryString,
ProcessUtilityContext processUtilityContext) ProcessUtilityContext processUtilityContext)