From 3dbaf5886b27cd764c6b64ac8c12d77758eeb7e2 Mon Sep 17 00:00:00 2001 From: Burak Velioglu Date: Thu, 20 Jan 2022 01:17:26 +0300 Subject: [PATCH] Address reviews --- src/backend/distributed/metadata/metadata_sync.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/backend/distributed/metadata/metadata_sync.c b/src/backend/distributed/metadata/metadata_sync.c index 1849b6c0f..9947d6435 100644 --- a/src/backend/distributed/metadata/metadata_sync.c +++ b/src/backend/distributed/metadata/metadata_sync.c @@ -84,7 +84,7 @@ char *EnableManualMetadataChangesForUser = ""; static void EnsureSequentialModeMetadataOperations(void); -static List * GetDistributedTableMetadataEvents(Oid relationId); +static List * CitusTableMetadataCreateCommandList(Oid relationId); static void EnsureObjectMetadataIsSane(int distributionArgumentIndex, int colocationId); static char * SchemaOwnerName(Oid objectId); @@ -643,11 +643,13 @@ DistributedObjectMetadataSyncCommandList(void) /* - * GetDistributedTableMetadataEvents returns the full set of DDL commands necessary to - * create the given distributed table metadata on a worker. + * CitusTableMetadataCreateCommandList returns the set of commands necessary to + * create the given distributed table metadata on a worker. It includes truncate + * trigger as well, since we need to create truncate trigger for tables owned by + * extensions and use it for handling metadata while truncating tables. */ static List * -GetDistributedTableMetadataEvents(Oid relationId) +CitusTableMetadataCreateCommandList(Oid relationId) { CitusTableCacheEntry *cacheEntry = GetCitusTableCacheEntry(relationId); @@ -1946,7 +1948,7 @@ CreateShellTableOnWorkers(Oid relationId) void CreateTableMetadataOnWorkers(Oid relationId) { - List *commandList = GetDistributedTableMetadataEvents(relationId); + List *commandList = CitusTableMetadataCreateCommandList(relationId); /* prevent recursive propagation */ SendCommandToWorkersWithMetadata(DISABLE_DDL_PROPAGATION);