external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve dependeny check for object to not have separate definition on different nodes

velioglu/check_all_obj_for_dep_and_dist
Burak Velioglu 2022-05-18 13:15:48 +03:00
parent 313104ab9b
commit 3ec1b9be2b
5 changed files with 7 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/distributed/commands/aggregate.c
View File

@ -70,11 +70,8 @@ PostprocessDefineAggregateStmt(Node *node, const char *queryString)
EnsureSequentialMode(OBJECT_AGGREGATE); EnsureSequentialMode(OBJECT_AGGREGATE);
/* If the aggregate has any unsupported dependency, create it locally */ /* If the aggregate has any unsupported dependency, create it locally */
DeferredErrorMessage *depError = DeferErrorIfHasUnsupportedDependency(&address); if (ErrorOrWarnIfObjectHasUnsupportedDependency(&address))
if (depError != NULL)
{ {
RaiseDeferredError(depError, WARNING);
return NIL; return NIL;
} }

5
src/backend/distributed/commands/collation.c
View File

@ -612,11 +612,8 @@ PostprocessDefineCollationStmt(Node *node, const char *queryString)
ObjectAddress collationAddress = ObjectAddress collationAddress =
DefineCollationStmtObjectAddress(node, false); DefineCollationStmtObjectAddress(node, false);
DeferredErrorMessage *errMsg = DeferErrorIfHasUnsupportedDependency( if (ErrorOrWarnIfObjectHasUnsupportedDependency(&collationAddress))
&collationAddress);
if (errMsg != NULL)
{ {
RaiseDeferredError(errMsg, WARNING);
return NIL; return NIL;
} }

5
src/backend/distributed/commands/function.c
View File

@ -1369,11 +1369,8 @@ PostprocessCreateFunctionStmt(Node *node, const char *queryString)
} }
/* If the function has any unsupported dependency, create it locally */ /* If the function has any unsupported dependency, create it locally */
DeferredErrorMessage *errMsg = DeferErrorIfHasUnsupportedDependency(&functionAddress); if (ErrorOrWarnIfObjectHasUnsupportedDependency(&functionAddress))
if (errMsg != NULL)
{ {
RaiseDeferredError(errMsg, WARNING);
return NIL; return NIL;
} }

8
src/backend/distributed/commands/text_search.c
View File

@ -93,10 +93,8 @@ PostprocessCreateTextSearchConfigurationStmt(Node *node, const char *queryString
ObjectAddress address = GetObjectAddressFromParseTree((Node *) stmt, false); ObjectAddress address = GetObjectAddressFromParseTree((Node *) stmt, false);
DeferredErrorMessage *errMsg = DeferErrorIfHasUnsupportedDependency(&address); if (ErrorOrWarnIfObjectHasUnsupportedDependency(&address))
if (errMsg != NULL)
{ {
RaiseDeferredError(errMsg, WARNING);
return NIL; return NIL;
} }
@ -142,10 +140,8 @@ PostprocessCreateTextSearchDictionaryStmt(Node *node, const char *queryString)
ObjectAddress address = GetObjectAddressFromParseTree((Node *) stmt, false); ObjectAddress address = GetObjectAddressFromParseTree((Node *) stmt, false);
DeferredErrorMessage *errMsg = DeferErrorIfHasUnsupportedDependency(&address); if (ErrorOrWarnIfObjectHasUnsupportedDependency(&address))
if (errMsg != NULL)
{ {
RaiseDeferredError(errMsg, WARNING);
return NIL; return NIL;
} }

8
src/backend/distributed/commands/type.c
View File

@ -161,10 +161,8 @@ PostprocessCompositeTypeStmt(Node *node, const char *queryString)
ObjectAddress typeAddress = GetObjectAddressFromParseTree(node, false); ObjectAddress typeAddress = GetObjectAddressFromParseTree(node, false);
/* If the type has any unsupported dependency, create it locally */ /* If the type has any unsupported dependency, create it locally */
DeferredErrorMessage *errMsg = DeferErrorIfHasUnsupportedDependency(&typeAddress); if (ErrorOrWarnIfObjectHasUnsupportedDependency(&typeAddress))
if (errMsg != NULL)
{ {
RaiseDeferredError(errMsg, WARNING);
return NIL; return NIL;
} }
@ -283,10 +281,8 @@ PostprocessCreateEnumStmt(Node *node, const char *queryString)
/* lookup type address of just created type */ /* lookup type address of just created type */
ObjectAddress typeAddress = GetObjectAddressFromParseTree(node, false); ObjectAddress typeAddress = GetObjectAddressFromParseTree(node, false);
DeferredErrorMessage *errMsg = DeferErrorIfHasUnsupportedDependency(&typeAddress); if (ErrorOrWarnIfObjectHasUnsupportedDependency(&typeAddress))
if (errMsg != NULL)
{ {
RaiseDeferredError(errMsg, WARNING);
return NIL; return NIL;
} }