Fix warnings

pg_dist_object-metadatasync
Jelte Fennema 2021-07-22 16:20:22 +02:00
parent 379f2a9b3b
commit 4133d38479
3 changed files with 5 additions and 6 deletions

View File

@ -83,7 +83,7 @@ static List * GetDistributedTableDDLEvents(Oid relationId);
static char * LocalGroupIdUpdateCommand(int32 groupId); static char * LocalGroupIdUpdateCommand(int32 groupId);
static void UpdateDistNodeBoolAttr(const char *nodeName, int32 nodePort, static void UpdateDistNodeBoolAttr(const char *nodeName, int32 nodePort,
int attrNum, bool value); int attrNum, bool value);
static List * DistributedObjectSyncCommandList(); static List * DistributedObjectSyncCommandList(void);
static List * SequenceDependencyCommandList(Oid relationId); static List * SequenceDependencyCommandList(Oid relationId);
static char * TruncateTriggerCreateCommand(Oid relationId); static char * TruncateTriggerCreateCommand(Oid relationId);
static char * SchemaOwnerName(Oid objectId); static char * SchemaOwnerName(Oid objectId);
@ -436,7 +436,7 @@ DropMetadataSnapshotOnNode(WorkerNode *workerNode)
* (vi) Queries that populate pg_dist_object * (vi) Queries that populate pg_dist_object
*/ */
List * List *
MetadataCreateCommands() MetadataCreateCommands(void)
{ {
List *metadataSnapshotCommandList = NIL; List *metadataSnapshotCommandList = NIL;
List *distributedTableList = CitusTableList(); List *distributedTableList = CitusTableList();
@ -620,7 +620,7 @@ MetadataCreateCommands()
static List * static List *
DistributedObjectSyncCommandList() DistributedObjectSyncCommandList(void)
{ {
List *commandList = NIL; List *commandList = NIL;

View File

@ -42,8 +42,7 @@ Datum
master_metadata_snapshot(PG_FUNCTION_ARGS) master_metadata_snapshot(PG_FUNCTION_ARGS)
{ {
List *dropSnapshotCommands = MetadataDropCommands(); List *dropSnapshotCommands = MetadataDropCommands();
List *newDistributedObjects = NIL; List *createSnapshotCommands = MetadataCreateCommands();
List *createSnapshotCommands = MetadataCreateCommands(&newDistributedObjects);
List *snapshotCommandList = NIL; List *snapshotCommandList = NIL;
int snapshotCommandIndex = 0; int snapshotCommandIndex = 0;
Oid ddlCommandTypeId = TEXTOID; Oid ddlCommandTypeId = TEXTOID;

View File

@ -31,7 +31,7 @@ typedef enum
extern void StartMetadataSyncToNode(const char *nodeNameString, int32 nodePort); extern void StartMetadataSyncToNode(const char *nodeNameString, int32 nodePort);
extern bool ClusterHasKnownMetadataWorkers(void); extern bool ClusterHasKnownMetadataWorkers(void);
extern bool ShouldSyncTableMetadata(Oid relationId); extern bool ShouldSyncTableMetadata(Oid relationId);
extern List * MetadataCreateCommands(); extern List * MetadataCreateCommands(void);
extern List * MetadataDropCommands(void); extern List * MetadataDropCommands(void);
extern char * DistributedObjectCreateCommand(const ObjectAddress *address, extern char * DistributedObjectCreateCommand(const ObjectAddress *address,
int32 *distributionArgumentIndex, int32 *distributionArgumentIndex,