From 48fab6f264e7c5d98f25ccf7415d24cb0b3a86e0 Mon Sep 17 00:00:00 2001 From: Jelte Fennema Date: Wed, 8 Jul 2020 14:57:48 +0200 Subject: [PATCH] Replace words that have bad associations (#3992) We had a few words in our codebase that static analysis flagged as having bad associations. (cherry picked from commit f6e2f1b1cbb2dab868824649fcd2b953e5465064) --- src/backend/distributed/commands/utility_hook.c | 2 +- src/backend/distributed/utils/enable_ssl.c | 4 ++-- src/include/distributed/connection_management.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/distributed/commands/utility_hook.c b/src/backend/distributed/commands/utility_hook.c index f3ed4d556..cd57cf1b7 100644 --- a/src/backend/distributed/commands/utility_hook.c +++ b/src/backend/distributed/commands/utility_hook.c @@ -915,7 +915,7 @@ NodeDDLTaskList(TargetWorkerSet targets, List *commands) { /* * if there are no nodes we don't have to plan any ddl tasks. Planning them would - * cause a hang in the executor. + * cause the executor to stop responding. */ return NIL; } diff --git a/src/backend/distributed/utils/enable_ssl.c b/src/backend/distributed/utils/enable_ssl.c index f3833923f..ebb07349a 100644 --- a/src/backend/distributed/utils/enable_ssl.c +++ b/src/backend/distributed/utils/enable_ssl.c @@ -367,8 +367,8 @@ CreateCertificate(EVP_PKEY *privateKey) * Postgres does not check the validity on the certificates, but we can't omit the * dates either to create a certificate that can be parsed. We settled on a validity * of 0 seconds. When postgres would fix the validity check in a future version it - * would fail right after an upgrade instead of setting a time bomb till certificate - * expiration date. + * would fail right after an upgrade. Instead of working until the certificate + * expiration date and then suddenly erroring out. */ X509_gmtime_adj(X509_get_notBefore(certificate), 0); X509_gmtime_adj(X509_get_notAfter(certificate), 0); diff --git a/src/include/distributed/connection_management.h b/src/include/distributed/connection_management.h index fdfe18568..6806333a0 100644 --- a/src/include/distributed/connection_management.h +++ b/src/include/distributed/connection_management.h @@ -96,7 +96,7 @@ typedef enum MultiConnectionStructInitializationState } MultiConnectionStructInitializationState; -/* declaring this directly above makes uncrustify go crazy */ +/* declaring this directly above causes uncrustify to format it badly */ typedef enum MultiConnectionMode MultiConnectionMode; typedef struct MultiConnection