Fix error message of start_metadata_sync_to_node

Single quotation mark is added around nodename to make the
error code consistent with master_add_node usage.
pull/1248/head
velioglu 2017-02-22 17:31:52 +03:00
parent e3e1436680
commit 4dbb69cfc3
1 changed files with 3 additions and 2 deletions

View File

@ -76,6 +76,7 @@ start_metadata_sync_to_node(PG_FUNCTION_ARGS)
int32 nodePort = PG_GETARG_INT32(1); int32 nodePort = PG_GETARG_INT32(1);
char *nodeNameString = text_to_cstring(nodeName); char *nodeNameString = text_to_cstring(nodeName);
char *extensionOwner = CitusExtensionOwnerName(); char *extensionOwner = CitusExtensionOwnerName();
char *escapedNodeName = quote_literal_cstr(nodeNameString);
WorkerNode *workerNode = NULL; WorkerNode *workerNode = NULL;
char *localGroupIdUpdateCommand = NULL; char *localGroupIdUpdateCommand = NULL;
@ -94,8 +95,8 @@ start_metadata_sync_to_node(PG_FUNCTION_ARGS)
{ {
ereport(ERROR, (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), ereport(ERROR, (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
errmsg("you cannot sync metadata to a non-existent node"), errmsg("you cannot sync metadata to a non-existent node"),
errhint("First, add the node with SELECT master_add_node(%s,%d)", errhint("First, add the node with SELECT master_add_node"
nodeNameString, nodePort))); "(%s,%d)", escapedNodeName, nodePort)));
} }
MarkNodeHasMetadata(nodeNameString, nodePort, true); MarkNodeHasMetadata(nodeNameString, nodePort, true);