external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Move identity column existance check to ConvertTable()

issue/6694
Gokhan Gulbiz 2023-03-10 10:51:44 +03:00
parent 55ebabc875
commit 4fb37f33cc
No known key found for this signature in database
GPG Key ID: 608EF06B6BD1B45B
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/distributed/commands/alter_table.c
View File

@ -406,8 +406,6 @@ UndistributeTable(TableConversionParameters *params)
params->shardCountIsNull = true; params->shardCountIsNull = true;
TableConversionState *con = CreateTableConversion(params); TableConversionState *con = CreateTableConversion(params);
ErrorIfTableHasIdentityColumn(params->relationId);
return ConvertTable(con); return ConvertTable(con);
} }
@ -437,7 +435,6 @@ AlterDistributedTable(TableConversionParameters *params)
EnsureHashDistributedTable(params->relationId); EnsureHashDistributedTable(params->relationId);
ErrorIfUnsupportedCascadeObjects(params->relationId); ErrorIfUnsupportedCascadeObjects(params->relationId);
ErrorIfTableHasIdentityColumn(params->relationId);
params->conversionType = ALTER_DISTRIBUTED_TABLE; params->conversionType = ALTER_DISTRIBUTED_TABLE;
TableConversionState *con = CreateTableConversion(params); TableConversionState *con = CreateTableConversion(params);
@ -502,7 +499,6 @@ AlterTableSetAccessMethod(TableConversionParameters *params)
} }
ErrorIfUnsupportedCascadeObjects(params->relationId); ErrorIfUnsupportedCascadeObjects(params->relationId);
ErrorIfTableHasIdentityColumn(params->relationId);
params->conversionType = ALTER_TABLE_SET_ACCESS_METHOD; params->conversionType = ALTER_TABLE_SET_ACCESS_METHOD;
params->shardCountIsNull = true; params->shardCountIsNull = true;
@ -932,6 +928,7 @@ CopyTableConversionReturnIntoCurrentContext(TableConversionReturn *tableConversi
static TableConversionReturn * static TableConversionReturn *
ConvertTable(TableConversionState *con) ConvertTable(TableConversionState *con)
{ {
ErrorIfTableHasIdentityColumn(con->relationId);
/* /*
* when there are many partitions or colocated tables, memory usage is * when there are many partitions or colocated tables, memory usage is
* accumulated. Free context for each call to ConvertTable. * accumulated. Free context for each call to ConvertTable.