external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Give WARNING if object is local, ERROR out if it is distributed

onder_view
Burak Velioglu 2022-04-20 17:53:33 +03:00
parent 81ea6c308c
commit 50201f4bec
2 changed files with 28 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/backend/distributed/commands/view.c
View File

@ -93,6 +93,11 @@ PostprocessViewStmt(Node *node, const char *queryString)
return NIL; return NIL;
} }
if (!HasAnyNodes())
{
return NIL;
}
ObjectAddress viewAddress = GetObjectAddressFromParseTree((Node *) stmt, false); ObjectAddress viewAddress = GetObjectAddressFromParseTree((Node *) stmt, false);
if (IsObjectAddressOwnedByExtension(&viewAddress, NULL)) if (IsObjectAddressOwnedByExtension(&viewAddress, NULL))
@ -105,12 +110,15 @@ PostprocessViewStmt(Node *node, const char *queryString)
if (errMsg != NULL) if (errMsg != NULL)
{ {
if (HasAnyNodes()) if (IsObjectDistributed(&viewAddress))
{
RaiseDeferredError(errMsg, ERROR);
}
else
{ {
RaiseDeferredError(errMsg, WARNING); RaiseDeferredError(errMsg, WARNING);
return NIL;
} }
return NIL;
} }
EnsureDependenciesExistOnAllNodes(&viewAddress); EnsureDependenciesExistOnAllNodes(&viewAddress);

22
src/backend/distributed/metadata/dependency.c
View File

@ -803,8 +803,11 @@ DeferErrorIfHasUnsupportedDependency(const ObjectAddress *objectAddress)
* Otherwise, callers are expected to throw the error returned from this * Otherwise, callers are expected to throw the error returned from this
* function as a hard one by ignoring the detail part. * function as a hard one by ignoring the detail part.
*/ */
appendStringInfo(detailInfo, "\"%s\" will be created only locally", if (!IsObjectDistributed(objectAddress))
objectDescription); {
appendStringInfo(detailInfo, "\"%s\" will be created only locally",
objectDescription);
}
if (SupportedDependencyByCitus(undistributableDependency)) if (SupportedDependencyByCitus(undistributableDependency))
{ {
@ -815,9 +818,18 @@ DeferErrorIfHasUnsupportedDependency(const ObjectAddress *objectAddress)
objectDescription, objectDescription,
dependencyDescription); dependencyDescription);
appendStringInfo(hintInfo, "Distribute \"%s\" first to distribute \"%s\"", if (IsObjectDistributed(objectAddress))
dependencyDescription, {
objectDescription); appendStringInfo(hintInfo, "Distribute \"%s\" first to update \"%s\" on worker nodes",
dependencyDescription,
objectDescription);
}
else
{
appendStringInfo(hintInfo, "Distribute \"%s\" first to distribute \"%s\"",
dependencyDescription,
objectDescription);
}
return DeferredError(ERRCODE_FEATURE_NOT_SUPPORTED, return DeferredError(ERRCODE_FEATURE_NOT_SUPPORTED,
errorInfo->data, detailInfo->data, hintInfo->data); errorInfo->data, detailInfo->data, hintInfo->data);