external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

default mode for shard splitting is set to auto. (#6179)

pull/6177/head
aykut-bozkurt 2022-08-17 12:18:47 +03:00 committed by GitHub
parent be06d65721
commit 52efe08642
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/distributed/sql/udfs/citus_split_shard_by_split_points/11.1-1.sql generated
View File

@ -5,8 +5,8 @@ CREATE OR REPLACE FUNCTION pg_catalog.citus_split_shard_by_split_points(
-- Use integer (consistent with other previously defined UDFs that take nodeId as integer) as for all practical purposes it is big enough. -- Use integer (consistent with other previously defined UDFs that take nodeId as integer) as for all practical purposes it is big enough.
node_ids integer[], node_ids integer[],
-- Three modes to be implemented: block_writes, force_logical and auto. -- Three modes to be implemented: block_writes, force_logical and auto.
-- Currently, the default / only supported mode is block_writes. -- The default mode is auto.
shard_transfer_mode citus.shard_transfer_mode default 'block_writes') shard_transfer_mode citus.shard_transfer_mode default 'auto')
RETURNS void RETURNS void
LANGUAGE C STRICT LANGUAGE C STRICT
AS 'MODULE_PATHNAME', $$citus_split_shard_by_split_points$$; AS 'MODULE_PATHNAME', $$citus_split_shard_by_split_points$$;

4
src/backend/distributed/sql/udfs/citus_split_shard_by_split_points/latest.sql
View File

@ -5,8 +5,8 @@ CREATE OR REPLACE FUNCTION pg_catalog.citus_split_shard_by_split_points(
-- Use integer (consistent with other previously defined UDFs that take nodeId as integer) as for all practical purposes it is big enough. -- Use integer (consistent with other previously defined UDFs that take nodeId as integer) as for all practical purposes it is big enough.
node_ids integer[], node_ids integer[],
-- Three modes to be implemented: block_writes, force_logical and auto. -- Three modes to be implemented: block_writes, force_logical and auto.
-- Currently, the default / only supported mode is block_writes. -- The default mode is auto.
shard_transfer_mode citus.shard_transfer_mode default 'block_writes') shard_transfer_mode citus.shard_transfer_mode default 'auto')
RETURNS void RETURNS void
LANGUAGE C STRICT LANGUAGE C STRICT
AS 'MODULE_PATHNAME', $$citus_split_shard_by_split_points$$; AS 'MODULE_PATHNAME', $$citus_split_shard_by_split_points$$;

3
src/test/regress/expected/citus_non_blocking_split_shards.out
View File

@ -446,8 +446,7 @@ SET citus.next_shard_id TO 8981041;
SELECT pg_catalog.citus_split_shard_by_split_points( SELECT pg_catalog.citus_split_shard_by_split_points(
8981031, 8981031,
ARRAY['-2120000000'], ARRAY['-2120000000'],
ARRAY[:worker_1_node, :worker_2_node], ARRAY[:worker_1_node, :worker_2_node]);
'auto');
ERROR: cannot use logical replication to transfer shards of the relation table_no_rep_id since it doesn't have a REPLICA IDENTITY or PRIMARY KEY ERROR: cannot use logical replication to transfer shards of the relation table_no_rep_id since it doesn't have a REPLICA IDENTITY or PRIMARY KEY
DETAIL: UPDATE and DELETE commands on the shard will error out during logical replication unless there is a REPLICA IDENTITY or PRIMARY KEY. DETAIL: UPDATE and DELETE commands on the shard will error out during logical replication unless there is a REPLICA IDENTITY or PRIMARY KEY.
HINT: If you wish to continue without a replica identity set the shard_transfer_mode to 'force_logical' or 'block_writes'. HINT: If you wish to continue without a replica identity set the shard_transfer_mode to 'force_logical' or 'block_writes'.

3
src/test/regress/sql/citus_non_blocking_split_shards.sql
View File

@ -242,8 +242,7 @@ SET citus.next_shard_id TO 8981041;
SELECT pg_catalog.citus_split_shard_by_split_points( SELECT pg_catalog.citus_split_shard_by_split_points(
8981031, 8981031,
ARRAY['-2120000000'], ARRAY['-2120000000'],
ARRAY[:worker_1_node, :worker_2_node], ARRAY[:worker_1_node, :worker_2_node]);
'auto');
SELECT shard.shardid, logicalrelid, shardminvalue, shardmaxvalue, nodename, nodeport SELECT shard.shardid, logicalrelid, shardminvalue, shardmaxvalue, nodename, nodeport
FROM pg_dist_shard AS shard FROM pg_dist_shard AS shard