external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Skip deadlock detection on the workers 

Do not run distributed deadlock detection
on the worker nodes to prevent errornous
decisions to kill the deadlocks.
pull/1595/head
Onder Kalaci 2017-08-17 19:33:39 +03:00
parent 0ddcd726c9
commit 550a5578d8
1 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/backend/distributed/transaction/distributed_deadlock_detection.c
View File

@ -101,12 +101,29 @@ check_distributed_deadlocks(PG_FUNCTION_ARGS)
bool bool
CheckForDistributedDeadlocks(void) CheckForDistributedDeadlocks(void)
{ {
WaitGraph *waitGraph = BuildGlobalWaitGraph(); WaitGraph *waitGraph = NULL;
HTAB *adjacencyLists = BuildAdjacencyListsForWaitGraph(waitGraph); HTAB *adjacencyLists = NULL;
HASH_SEQ_STATUS status; HASH_SEQ_STATUS status;
TransactionNode *transactionNode = NULL; TransactionNode *transactionNode = NULL;
int edgeCount = waitGraph->edgeCount; int edgeCount = 0;
int localGroupId = GetLocalGroupId(); int localGroupId = GetLocalGroupId();
List *workerNodeList = ActiveReadableNodeList();
/*
* We don't need to do any distributed deadlock checking if there
* are no worker nodes. This might even be problematic for a non-mx
* worker node which has the same group id with its master (i.e., 0),
* which may erroneously decide to kill the deadlocks happening on it.
*/
if (list_length(workerNodeList) == 0)
{
return false;
}
waitGraph = BuildGlobalWaitGraph();
adjacencyLists = BuildAdjacencyListsForWaitGraph(waitGraph);
edgeCount = waitGraph->edgeCount;
/* /*
* We iterate on transaction nodes and search for deadlocks where the * We iterate on transaction nodes and search for deadlocks where the