external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Keep read lock until we are done with identity columns check

issue/6694
Gokhan Gulbiz 2023-03-10 10:43:19 +03:00
parent b649df41c5
commit 55ebabc875
No known key found for this signature in database
GPG Key ID: 608EF06B6BD1B45B
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/distributed/commands/table.c
View File

@ -3981,7 +3981,6 @@ ErrorIfTableHasUnsupportedIdentityColumn(Oid relationId)
{ {
Relation relation = relation_open(relationId, AccessShareLock); Relation relation = relation_open(relationId, AccessShareLock);
TupleDesc tupleDescriptor = RelationGetDescr(relation); TupleDesc tupleDescriptor = RelationGetDescr(relation);
relation_close(relation, AccessShareLock);
for (int attributeIndex = 0; attributeIndex < tupleDescriptor->natts; for (int attributeIndex = 0; attributeIndex < tupleDescriptor->natts;
attributeIndex++) attributeIndex++)
@ -3990,11 +3989,14 @@ ErrorIfTableHasUnsupportedIdentityColumn(Oid relationId)
if (attributeForm->attidentity && attributeForm->atttypid != INT8OID) if (attributeForm->attidentity && attributeForm->atttypid != INT8OID)
{ {
relation_close(relation, AccessShareLock);
ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg( errmsg(
"cannot complete operation on a table with smallint/int identity column"))); "cannot complete operation on a table with smallint/int identity column")));
} }
} }
relation_close(relation, AccessShareLock);
} }
@ -4006,7 +4008,6 @@ ErrorIfTableHasIdentityColumn(Oid relationId)
{ {
Relation relation = relation_open(relationId, AccessShareLock); Relation relation = relation_open(relationId, AccessShareLock);
TupleDesc tupleDescriptor = RelationGetDescr(relation); TupleDesc tupleDescriptor = RelationGetDescr(relation);
relation_close(relation, NoLock);
for (int attributeIndex = 0; attributeIndex < tupleDescriptor->natts; for (int attributeIndex = 0; attributeIndex < tupleDescriptor->natts;
attributeIndex++) attributeIndex++)
@ -4015,9 +4016,12 @@ ErrorIfTableHasIdentityColumn(Oid relationId)
if (attributeForm->attidentity) if (attributeForm->attidentity)
{ {
relation_close(relation, AccessShareLock);
ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg( errmsg(
"cannot complete operation on a table with identity column"))); "cannot complete operation on a table with identity column")));
} }
} }
relation_close(relation, NoLock);
} }