From 58facee439a6c41e12903afc1fa5b4ce67946b24 Mon Sep 17 00:00:00 2001
From: Nitish Upreti <niupre@microsoft.com>
Date: Sun, 19 Jun 2022 17:41:38 -0700
Subject: [PATCH] Fixing UDF definitions

---
 src/backend/distributed/operations/shard_split.c              | 4 ----
 .../sql/udfs/citus_split_shard_by_split_points/11.0-2.sql     | 2 +-
 .../sql/udfs/citus_split_shard_by_split_points/latest.sql     | 2 +-
 src/backend/distributed/sql/udfs/worker_split_copy/11.0-2.sql | 4 ++--
 src/backend/distributed/sql/udfs/worker_split_copy/latest.sql | 4 ++--
 5 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/src/backend/distributed/operations/shard_split.c b/src/backend/distributed/operations/shard_split.c
index 2fe862480..1680ebe0c 100644
--- a/src/backend/distributed/operations/shard_split.c
+++ b/src/backend/distributed/operations/shard_split.c
@@ -73,10 +73,6 @@ static const char *const SplitTargetName[] =
 	[SHARD_SPLIT_API] = "shard",
 	[ISOLATE_TENANT_TO_NEW_SHARD] = "tenant",
 };
-static const char *const SplitOperationType[] =
-{
-	[BLOCKING_SPLIT] = "blocking"
-};
 
 /* Function definitions */
 
diff --git a/src/backend/distributed/sql/udfs/citus_split_shard_by_split_points/11.0-2.sql b/src/backend/distributed/sql/udfs/citus_split_shard_by_split_points/11.0-2.sql
index 9369d356c..559769260 100644
--- a/src/backend/distributed/sql/udfs/citus_split_shard_by_split_points/11.0-2.sql
+++ b/src/backend/distributed/sql/udfs/citus_split_shard_by_split_points/11.0-2.sql
@@ -18,5 +18,5 @@ CREATE OR REPLACE FUNCTION pg_catalog.citus_split_shard_by_split_points(
 RETURNS void
 LANGUAGE C STRICT
 AS 'MODULE_PATHNAME', $$citus_split_shard_by_split_points$$;
-COMMENT ON FUNCTION pg_catalog.citus_split_shard_by_split_points(shard_id bigint, split_points integer[], nodeIds integer[], citus.split_mode)
+COMMENT ON FUNCTION pg_catalog.citus_split_shard_by_split_points(shard_id bigint, split_points text[], nodeIds integer[], citus.split_mode)
     IS 'split a shard using split mode.';
diff --git a/src/backend/distributed/sql/udfs/citus_split_shard_by_split_points/latest.sql b/src/backend/distributed/sql/udfs/citus_split_shard_by_split_points/latest.sql
index 9369d356c..559769260 100644
--- a/src/backend/distributed/sql/udfs/citus_split_shard_by_split_points/latest.sql
+++ b/src/backend/distributed/sql/udfs/citus_split_shard_by_split_points/latest.sql
@@ -18,5 +18,5 @@ CREATE OR REPLACE FUNCTION pg_catalog.citus_split_shard_by_split_points(
 RETURNS void
 LANGUAGE C STRICT
 AS 'MODULE_PATHNAME', $$citus_split_shard_by_split_points$$;
-COMMENT ON FUNCTION pg_catalog.citus_split_shard_by_split_points(shard_id bigint, split_points integer[], nodeIds integer[], citus.split_mode)
+COMMENT ON FUNCTION pg_catalog.citus_split_shard_by_split_points(shard_id bigint, split_points text[], nodeIds integer[], citus.split_mode)
     IS 'split a shard using split mode.';
diff --git a/src/backend/distributed/sql/udfs/worker_split_copy/11.0-2.sql b/src/backend/distributed/sql/udfs/worker_split_copy/11.0-2.sql
index a21840783..9a69b3b68 100644
--- a/src/backend/distributed/sql/udfs/worker_split_copy/11.0-2.sql
+++ b/src/backend/distributed/sql/udfs/worker_split_copy/11.0-2.sql
@@ -9,9 +9,9 @@ CREATE TYPE citus.split_copy_info AS (
 
 CREATE OR REPLACE FUNCTION pg_catalog.worker_split_copy(
     source_shard_id bigint,
-    splitShardInfo citus.split_shard_info[])
+    splitCopyInfo citus.split_copy_info[])
 RETURNS void
 LANGUAGE C STRICT
 AS 'MODULE_PATHNAME', $$worker_split_copy$$;
-COMMENT ON FUNCTION pg_catalog.worker_split_copy(splitShardInfo citus.split_shard_info[])
+COMMENT ON FUNCTION pg_catalog.worker_split_copy(source_shard_id bigint, splitCopyInfo citus.split_copy_info[])
     IS 'Perform split copy for shard'
diff --git a/src/backend/distributed/sql/udfs/worker_split_copy/latest.sql b/src/backend/distributed/sql/udfs/worker_split_copy/latest.sql
index a21840783..9a69b3b68 100644
--- a/src/backend/distributed/sql/udfs/worker_split_copy/latest.sql
+++ b/src/backend/distributed/sql/udfs/worker_split_copy/latest.sql
@@ -9,9 +9,9 @@ CREATE TYPE citus.split_copy_info AS (
 
 CREATE OR REPLACE FUNCTION pg_catalog.worker_split_copy(
     source_shard_id bigint,
-    splitShardInfo citus.split_shard_info[])
+    splitCopyInfo citus.split_copy_info[])
 RETURNS void
 LANGUAGE C STRICT
 AS 'MODULE_PATHNAME', $$worker_split_copy$$;
-COMMENT ON FUNCTION pg_catalog.worker_split_copy(splitShardInfo citus.split_shard_info[])
+COMMENT ON FUNCTION pg_catalog.worker_split_copy(source_shard_id bigint, splitCopyInfo citus.split_copy_info[])
     IS 'Perform split copy for shard'