From 59e54de54dc5ffc914246dc76f7a6954f5e8ede8 Mon Sep 17 00:00:00 2001 From: exialin Date: Sat, 18 May 2019 10:58:18 +0800 Subject: [PATCH] Minor code clean-up --- src/backend/distributed/planner/multi_physical_planner.c | 2 -- src/backend/distributed/utils/metadata_cache.c | 2 +- src/include/distributed/metadata_cache.h | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/backend/distributed/planner/multi_physical_planner.c b/src/backend/distributed/planner/multi_physical_planner.c index b9a8bbc97..c1f949760 100644 --- a/src/backend/distributed/planner/multi_physical_planner.c +++ b/src/backend/distributed/planner/multi_physical_planner.c @@ -3452,7 +3452,6 @@ JoinSequenceArray(List *rangeTableFragmentsList, Query *jobQuery, List *depended uint32 rangeTableCount = (uint32) list_length(rangeTableList); uint32 sequenceNodeSize = sizeof(JoinSequenceNode); uint32 joinedTableCount = 0; - List *joinedTableList = NIL; List *joinExprList = NIL; ListCell *joinExprCell = NULL; uint32 firstRangeTableId = 1; @@ -3574,7 +3573,6 @@ JoinSequenceArray(List *rangeTableFragmentsList, Query *jobQuery, List *depended nextJoinSequenceNode->joiningRangeTableId = NON_PRUNABLE_JOIN; } - joinedTableList = lappend_int(joinedTableList, nextRangeTableId); joinedTableCount++; } diff --git a/src/backend/distributed/utils/metadata_cache.c b/src/backend/distributed/utils/metadata_cache.c index 5fa3f0b99..4f1c0bb64 100644 --- a/src/backend/distributed/utils/metadata_cache.c +++ b/src/backend/distributed/utils/metadata_cache.c @@ -167,7 +167,7 @@ static bool workerNodeHashValid = false; /* default value is -1, for coordinator it's 0 and for worker nodes > 0 */ static int32 LocalGroupId = -1; -/* built first time through in InitializePartitionCache */ +/* built first time through in InitializeDistTableCache */ static ScanKeyData DistPartitionScanKey[1]; static ScanKeyData DistShardScanKey[1]; diff --git a/src/include/distributed/metadata_cache.h b/src/include/distributed/metadata_cache.h index dfe2bed5e..c765ababd 100644 --- a/src/include/distributed/metadata_cache.h +++ b/src/include/distributed/metadata_cache.h @@ -63,7 +63,7 @@ typedef struct /* * Comparator for partition interval type (different from - * shardValueCompareFunction if hash-partitioned), NULL if + * shardColumnCompareFunction if hash-partitioned), NULL if * DISTRIBUTE_BY_NONE. */ FmgrInfo *shardIntervalCompareFunction;