From 5aae80f2849e8c627a0660158d19d97bfb40d350 Mon Sep 17 00:00:00 2001
From: gindibay <gindibay@microsoft.com>
Date: Wed, 22 Nov 2023 01:49:14 +0300
Subject: [PATCH] Fixes review notes

---
 .../expected/alter_database_propagation.out   | 37 ++++++++++++++++---
 .../sql/alter_database_propagation.sql        | 29 +++++++++------
 2 files changed, 49 insertions(+), 17 deletions(-)

diff --git a/src/test/regress/expected/alter_database_propagation.out b/src/test/regress/expected/alter_database_propagation.out
index 722c8973f..fbef9aee6 100644
--- a/src/test/regress/expected/alter_database_propagation.out
+++ b/src/test/regress/expected/alter_database_propagation.out
@@ -179,11 +179,36 @@ DETAIL:  on server postgres@localhost:xxxxx connectionId: xxxxxxx
 NOTICE:  issuing ALTER DATABASE regression2 RENAME TO regression3
 DETAIL:  on server postgres@localhost:xxxxx connectionId: xxxxxxx
 drop database regression3;
+create database regression4;
+SELECT result FROM run_command_on_all_nodes(
+  $$
+  ALTER TABLESPACE alter_db_tablespace RENAME TO "ts-needs\!escape"
+  $$
+);
+      result
+---------------------------------------------------------------------
+ ALTER TABLESPACE
+ ALTER TABLESPACE
+ ALTER TABLESPACE
+(3 rows)
+
+alter database regression4 set TABLESPACE "ts-needs\!escape";
+NOTICE:  issuing ALTER DATABASE regression4 SET TABLESPACE "ts-needs\!escape";
+DETAIL:  on server postgres@localhost:xxxxx connectionId: xxxxxxx
+NOTICE:  issuing ALTER DATABASE regression4 SET TABLESPACE "ts-needs\!escape";
+DETAIL:  on server postgres@localhost:xxxxx connectionId: xxxxxxx
+drop database regression4;
 set citus.log_remote_commands = false;
 set citus.enable_create_database_propagation=off;
-drop tablespace alter_db_tablespace;
-\c - - - :worker_1_port
-drop tablespace alter_db_tablespace;
-\c - - - :worker_2_port
-drop tablespace alter_db_tablespace;
-\c - - - :master_port
+SELECT result FROM run_command_on_all_nodes(
+  $$
+  drop tablespace "ts-needs\!escape"
+  $$
+);
+     result
+---------------------------------------------------------------------
+ DROP TABLESPACE
+ DROP TABLESPACE
+ DROP TABLESPACE
+(3 rows)
+
diff --git a/src/test/regress/sql/alter_database_propagation.sql b/src/test/regress/sql/alter_database_propagation.sql
index 693ff8aaa..c10b9f9cf 100644
--- a/src/test/regress/sql/alter_database_propagation.sql
+++ b/src/test/regress/sql/alter_database_propagation.sql
@@ -78,19 +78,26 @@ alter database regression2 rename to regression3;
 
 drop database regression3;
 
+create database regression4;
+
+
+SELECT result FROM run_command_on_all_nodes(
+  $$
+  ALTER TABLESPACE alter_db_tablespace RENAME TO "ts-needs\!escape"
+  $$
+);
+
+alter database regression4 set TABLESPACE "ts-needs\!escape";
+
+drop database regression4;
+
 set citus.log_remote_commands = false;
 set citus.enable_create_database_propagation=off;
 
-drop tablespace alter_db_tablespace;
-
-\c - - - :worker_1_port
-
-drop tablespace alter_db_tablespace;
-
-\c - - - :worker_2_port
-
-drop tablespace alter_db_tablespace;
-
-\c - - - :master_port
+SELECT result FROM run_command_on_all_nodes(
+  $$
+  drop tablespace "ts-needs\!escape"
+  $$
+);