From 5d7924e7c76397e5e3e18e87256e1dc61d4f59af Mon Sep 17 00:00:00 2001 From: Gokhan Gulbiz Date: Thu, 26 Oct 2023 16:50:33 +0300 Subject: [PATCH] Adjust check-style --- .github/workflows/build_and_test.yml | 30 +++++++++++----------------- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index 41bcf21ec..00b573166 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -61,24 +61,22 @@ jobs: fetch-depth: 0 - name: Check C Style run: citus_indent --check - - name: Check Python style - run: black --check . - - name: Check Python import order - run: isort --check . - - name: Check Python lints - run: flake8 . - name: Fix whitespace - run: ci/editorconfig.sh && git diff --exit-code + run: ci/editorconfig.sh + - name: Check if whitespace fixing changed anything, install editorconfig if it did + run: git diff --exit-code - name: Remove useless declarations - run: ci/remove_useless_declarations.sh && git diff --cached --exit-code + run: ci/remove_useless_declarations.sh + - name: Check if changed + run: git diff --cached --exit-code - name: Normalize test output - run: ci/normalize_expected.sh && git diff --exit-code + run: ci/normalize_expected.sh + - name: Check if changed + run: git diff --exit-code - name: Check for C-style comments in migration files - run: ci/disallow_c_comments_in_migrations.sh && git diff --exit-code - - name: 'Check for comment--cached ns that start with # character in spec files' - run: ci/disallow_hash_comments_in_spec_files.sh && git diff --exit-code - - name: Check for gitignore entries .for source files - run: ci/fix_gitignore.sh && git diff --exit-code + run: ci/disallow_c_comments_in_migrations.sh + - name: Check if changed + run: git diff --exit-code - name: Check for lengths of changelog entries run: ci/disallow_long_changelog_entries.sh - name: Check for banned C API usage @@ -87,10 +85,6 @@ jobs: run: ci/check_all_tests_are_run.sh - name: Check if all CI scripts are actually run run: ci/check_all_ci_scripts_are_run.sh - - name: Check if all GUCs are sorted alphabetically - run: ci/check_gucs_are_alphabetically_sorted.sh - - name: Check for missing downgrade scripts - run: ci/check_migration_files.sh build: needs: params name: Build for PG ${{ matrix.pg_version}}