enable propagation warnings before postgres vanilla tests (#6081)

src/backend/distributed/commands/cluster.c

@@ -38,10 +38,13 @@ PreprocessClusterStmt(Node *node, const char *clusterCommand,
 	bool missingOK = false;
 
 	if (clusterStmt->relation == NULL)
+	{
+		if (EnableUnsupportedFeatureMessages)
 		{
 			ereport(WARNING, (errmsg("not propagating CLUSTER command to worker nodes"),
 							  errhint("Provide a specific table in order to CLUSTER "
 									  "distributed tables.")));
+		}
 
 		return NIL;
 	}

src/backend/distributed/commands/common.c

@@ -73,8 +73,12 @@ PostprocessCreateDistributedObjectFromCatalogStmt(Node *stmt, const char *queryS
 	DeferredErrorMessage *depError = DeferErrorIfAnyObjectHasUnsupportedDependency(
 		addresses);
 	if (depError != NULL)
+	{
+		if (EnableUnsupportedFeatureMessages)
 		{
 			RaiseDeferredError(depError, WARNING);
+		}
+
 		return NIL;
 	}
 

src/backend/distributed/commands/function.c

@@ -1386,8 +1386,12 @@ PostprocessCreateFunctionStmt(Node *node, const char *queryString)
 		functionAddresses);
 
 	if (errMsg != NULL)
+	{
+		if (EnableUnsupportedFeatureMessages)
 		{
 			RaiseDeferredError(errMsg, WARNING);
+		}
+
 		return NIL;
 	}
 

src/backend/distributed/commands/table.c

@@ -1753,11 +1753,14 @@ AnyForeignKeyDependsOnIndex(Oid indexId)
 List *
 PreprocessAlterTableMoveAllStmt(Node *node, const char *queryString,
 								ProcessUtilityContext processUtilityContext)
+{
+	if (EnableUnsupportedFeatureMessages)
 	{
 		ereport(WARNING, (errmsg("not propagating ALTER TABLE ALL IN TABLESPACE "
 								 "commands to worker nodes"),
 						  errhint("Connect to worker nodes directly to manually "
 								  "move all tables.")));
+	}
 
 	return NIL;
 }

src/backend/distributed/commands/utility_hook.c

@@ -734,12 +734,16 @@ ProcessUtilityInternal(PlannedStmt *pstmt,
 		if (IsA(parsetree, RenameStmt) && ((RenameStmt *) parsetree)->renameType ==
 			OBJECT_ROLE && EnableAlterRolePropagation)
 		{
-			ereport(NOTICE, (errmsg("not propagating ALTER ROLE ... RENAME TO commands "
+			if (EnableUnsupportedFeatureMessages)
+			{
+				ereport(NOTICE, (errmsg(
+									 "not propagating ALTER ROLE ... RENAME TO commands "
 									 "to worker nodes"),
 								 errhint("Connect to worker nodes directly to manually "
 										 "rename the role")));
 			}
 		}
+	}
 
 	if (IsA(parsetree, CreateStmt))
 	{

src/backend/distributed/shared_library_init.c

@@ -48,6 +48,7 @@
 #include "distributed/local_executor.h"
 #include "distributed/local_distributed_join_planner.h"
 #include "distributed/locally_reserved_shared_connections.h"
+#include "distributed/log_utils.h"
 #include "distributed/maintenanced.h"
 #include "distributed/shard_cleaner.h"
 #include "distributed/metadata_utility.h"
@@ -1153,6 +1154,17 @@ RegisterCitusConfigVariables(void)
 		GUC_STANDARD,
 		NULL, NULL, NULL);
 
+	DefineCustomBoolVariable(
+		"citus.enable_unsupported_feature_messages",
+		gettext_noop("Controls showing of some citus related messages. It is intended to "
+					 "be used before vanilla tests to stop unwanted citus messages."),
+		NULL,
+		&EnableUnsupportedFeatureMessages,
+		true,
+		PGC_SUSET,
+		GUC_SUPERUSER_ONLY | GUC_NO_SHOW_ALL,
+		NULL, NULL, NULL);
+
 	DefineCustomBoolVariable(
 		"citus.enable_version_checks",
 		gettext_noop("Enables version checks during CREATE/ALTER EXTENSION commands"),

src/backend/distributed/utils/log_utils.c

@@ -23,6 +23,12 @@
 #endif
 
 
+/*
+ * GUC controls showing of some of the unwanted citus messages, it is intended to be set false
+ * before vanilla tests to not break postgres test logs.
+ */
+bool EnableUnsupportedFeatureMessages = true;
+
 /*
  * IsLoggableLevel returns true if either of client or server log guc is configured to
  * log the given log level.

src/include/distributed/log_utils.h

@@ -16,6 +16,8 @@
 #define CITUS_LOG_LEVEL_OFF 0
 
 
+extern bool EnableUnsupportedFeatureMessages;
+
 extern bool IsLoggableLevel(int logLevel);
 extern char * HashLogMessage(const char *text);
 

src/test/regress/pg_regress_multi.pl

@@ -500,6 +500,9 @@ if(!$vanillaDev && $vanillatest)
 {
     # we enable hiding the citus dependent objects from pg meta class queries to not break postgres vanilla test behaviour
     push(@pgOptions, "citus.hide_citus_dependent_objects=true");
+
+    # we disable citus related unwanted messages to not break postgres vanilla test behaviour.
+    push(@pgOptions, "citus.enable_unsupported_feature_messages=false");
 }
 
 if ($useMitmproxy)