external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review 

Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
pull/7563/head
Gürkan İndibay 2024-04-02 09:14:35 +03:00 committed by GitHub
parent 179f2e5fad
commit 62de6dc0b4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/distributed/commands/database.c
View File

@ -699,12 +699,8 @@ List *
PreprocessAlterDatabaseOwnerStmt(Node *node, const char *queryString, PreprocessAlterDatabaseOwnerStmt(Node *node, const char *queryString,
ProcessUtilityContext processUtilityContext) ProcessUtilityContext processUtilityContext)
{ {
const DistributeObjectOps *ops = GetDistributeObjectOps(node); if (!EnableAlterDatabaseOwner)
Assert(ops != NULL);
if (ops->featureFlag && *ops->featureFlag == false)
{ {
/* not propagating when a configured feature flag is turned off by the user */
return NIL; return NIL;
} }
@ -717,6 +713,7 @@ PreprocessAlterDatabaseOwnerStmt(Node *node, const char *queryString,
{ {
return NIL; return NIL;
} }
EnsurePropagationToCoordinator(); EnsurePropagationToCoordinator();
AlterOwnerStmt *stmt = (AlterOwnerStmt *) node; AlterOwnerStmt *stmt = (AlterOwnerStmt *) node;

4
src/backend/distributed/commands/non_main_db_distribute_object_ops.c
View File

@ -76,6 +76,10 @@ static bool GrantStmtCheckSupportedObjectType(Node *node);
static bool SecLabelStmtCheckSupportedObjectType(Node *node); static bool SecLabelStmtCheckSupportedObjectType(Node *node);
static bool AlterDbRenameCheckSupportedObjectType(Node *node); static bool AlterDbRenameCheckSupportedObjectType(Node *node);
static bool AlterDbOwnerCheckSupportedObjectType(Node *node); static bool AlterDbOwnerCheckSupportedObjectType(Node *node);
/*
* cannotBeExecutedInTransaction callbacks for OperationArray.
*/
static bool CannotBeExecutedInTransaction_True(Node *node); static bool CannotBeExecutedInTransaction_True(Node *node);
static bool CannotBeExecutedInTransaction_False(Node *node); static bool CannotBeExecutedInTransaction_False(Node *node);
static bool AlterDbCannotBeExecutedInTransaction(Node *node); static bool AlterDbCannotBeExecutedInTransaction(Node *node);

1
src/include/distributed/commands.h
View File

@ -236,7 +236,6 @@ extern List * PreprocessAlterDatabaseRefreshCollStmt(Node *node, const char *que
processUtilityContext); processUtilityContext);
extern List * PreprocessAlterDatabaseOwnerStmt(Node *node, const char *queryString, extern List * PreprocessAlterDatabaseOwnerStmt(Node *node, const char *queryString,
ProcessUtilityContext processUtilityContext); ProcessUtilityContext processUtilityContext);
extern List * GetDatabaseMetadataSyncCommands(Oid dbOid); extern List * GetDatabaseMetadataSyncCommands(Oid dbOid);