external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge 37220a93f3 into 4cd8bb1b67

pull/6831/merge
Onur Tirtir 2025-06-24 10:45:01 -07:00 committed by GitHub
parent 4cd8bb1b67 37220a93f3
commit 656aa03589
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/backend/distributed/planner/query_pushdown_planning.c
View File

@ -424,38 +424,14 @@ IsOuterJoinExpr(Node *node)
bool bool
SafeToPushdownWindowFunction(Query *query, StringInfo *errorDetail) SafeToPushdownWindowFunction(Query *query, StringInfo *errorDetail)
{ {
ListCell *windowClauseCell = NULL;
List *windowClauseList = query->windowClause;
/*
* We need to check each window clause separately if there is a partition by clause
* and if it is partitioned on the distribution column.
*/
foreach(windowClauseCell, windowClauseList)
{
WindowClause *windowClause = lfirst(windowClauseCell);
if (!windowClause->partitionClause)
{
if (errorDetail)
{
*errorDetail = makeStringInfo();
appendStringInfoString(*errorDetail,
"Window functions without PARTITION BY on distribution "
"column is currently unsupported");
}
return false;
}
}
if (!WindowPartitionOnDistributionColumn(query)) if (!WindowPartitionOnDistributionColumn(query))
{ {
if (errorDetail) if (errorDetail)
{ {
*errorDetail = makeStringInfo(); *errorDetail = makeStringInfo();
appendStringInfoString(*errorDetail, appendStringInfoString(*errorDetail,
"Window functions with PARTITION BY list missing distribution " "Window functions should have a PARTITION BY clause list "
"column is currently unsupported"); "that contains distribution column");
} }
return false; return false;
} }