external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use good initdb options in arbitrary configs tests (#5802) 

In `pg_regress_multi.pl` we're running `initdb` with some options that
the `common.py` `initdb` is currently not using. All these flags seem
reasonable, so this brings `common.py` in line with
`pg_regress_multi.pl`.

In passing change the `--nosync` flag to `--no-sync`, since that's what
the PG documentation lists as the official option name (but both work).
pull/5816/head
Jelte Fennema 2022-03-17 13:22:23 +01:00 committed by GitHub
parent b0e406a478
commit 68bfc8d1c0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/test/regress/citus_tests/common.py
View File

@ -45,6 +45,12 @@ def initialize_db_for_cluster(pg_path, rel_data_path, settings, node_names):
abs_data_path, abs_data_path,
"--username", "--username",
USER, USER,
"--no-sync",
# --allow-group-access is used to ensure we set permissions on
# private keys correctly
"--allow-group-access",
"--encoding",
"UTF8"
] ]
subprocess.run(command, check=True) subprocess.run(command, check=True)
add_settings(abs_data_path, settings) add_settings(abs_data_path, settings)

4
src/test/regress/pg_regress_multi.pl
View File

@ -669,14 +669,14 @@ if (!$conninfo)
# Create new data directories, copy workers for speed # Create new data directories, copy workers for speed
# --allow-group-access is used to ensure we set permissions on private keys # --allow-group-access is used to ensure we set permissions on private keys
# correctly # correctly
system(catfile("$bindir", "initdb"), ("--nosync", "--allow-group-access", "-U", $user, "--encoding", "UTF8", catfile($TMP_CHECKDIR, $MASTERDIR, "data"))) == 0 system(catfile("$bindir", "initdb"), ("--no-sync", "--allow-group-access", "-U", $user, "--encoding", "UTF8", catfile($TMP_CHECKDIR, $MASTERDIR, "data"))) == 0
or die "Could not create $MASTERDIR data directory"; or die "Could not create $MASTERDIR data directory";
if ($usingWindows) if ($usingWindows)
{ {
for my $port (@workerPorts) for my $port (@workerPorts)
{ {
system(catfile("$bindir", "initdb"), ("--nosync", "--allow-group-access", "-U", $user, "--encoding", "UTF8", catfile($TMP_CHECKDIR, "worker.$port", "data"))) == 0 system(catfile("$bindir", "initdb"), ("--no-sync", "--allow-group-access", "-U", $user, "--encoding", "UTF8", catfile($TMP_CHECKDIR, "worker.$port", "data"))) == 0
or die "Could not create worker data directory"; or die "Could not create worker data directory";
} }
} }